fix: add failsafe to ensure that Sponsors queries contain only sponsors CPT (#221)

* fix: add failsafe to ensure that Sponsors queries contain only sponsors CPT

* fix: phpcs error

Author: dkoo

includes/class-core.php

@@ -50,6 +50,7 @@ public function __construct() {
 		add_action( 'init', [ __CLASS__, 'init' ] );
 		add_filter( 'newspack_ads_should_show_ads', [ __CLASS__, 'suppress_ads' ], 10, 2 );
 		add_filter( 'newspack_ads_ad_targeting', [ __CLASS__, 'ad_targeting' ], 10, 2 );
+		add_action( 'pre_get_posts', [ __CLASS__, 'ensure_only_sponsors' ] );
 	}
 
 	/**
@@ -518,6 +519,18 @@ public static function create_shadow_term( $post ) {
 
 		return $new_term;
 	}
+
+	/**
+	 * Failsafe to ensure that sponsors queries only fetch sponsors post types.
+	 * Other plugins may have query filters to add other post types to queries.
+	 *
+	 * @param WP_Query $query Query.
+	 */
+	public static function ensure_only_sponsors( $query ) {
+		if ( boolval( $query->get( 'is_sponsors' ) ) ) {
+			$query->set( 'post_type', self::NEWSPACK_SPONSORS_CPT ); // phpcs:ignore WordPressVIPMinimum.Hooks.PreGetPosts.PreGetPosts
+		}
+	}
 }
 
 Core::instance();

includes/theme-helpers.php

@@ -285,6 +285,7 @@ function( $sponsor ) use ( $id ) {
 function get_related_post( $slug ) {
 	$related_post = new \WP_Query(
 		[
+			'is_sponsors'    => 1,
 			'post_type'      => Core::NEWSPACK_SPONSORS_CPT,
 			'posts_per_page' => 1,
 			'post_status'    => 'publish',
@@ -333,6 +334,7 @@ function get_sponsor_posts_for_terms( $terms ) {
 
 	$sponsor_posts = new \WP_Query(
 		[
+			'is_sponsors'    => 1,
 			'post_type'      => Core::NEWSPACK_SPONSORS_CPT,
 			'posts_per_page' => 100,
 			'post_status'    => 'publish',