chore: make tests not silent if DEBUG set (#10130)

this was a gotcha as this is easy to forget. If you want silence, don't
set DEBUG

Author: ludamad

yarn-project/foundation/src/log/logger.ts

@@ -12,9 +12,14 @@ export type LogLevel = (typeof LogLevels)[number];
 
 function getLogLevel() {
   const envLogLevel = process.env.LOG_LEVEL?.toLowerCase() as LogLevel;
-  const defaultNonTestLogLevel =
-    process.env.DEBUG === undefined || process.env.DEBUG === '' ? ('info' as const) : ('debug' as const);
-  const defaultLogLevel = process.env.NODE_ENV === 'test' ? ('silent' as const) : defaultNonTestLogLevel;
+  let defaultLogLevel: LogLevel = 'info';
+  if (process.env.DEBUG) {
+    // if we set DEBUG to a non-empty string, use debug as default
+    defaultLogLevel = 'debug';
+  } else if (process.env.NODE_ENV === 'test') {
+    // otherwise, be silent in tests as these are frequently ran en-masse
+    defaultLogLevel = 'silent';
+  }
   return LogLevels.includes(envLogLevel) ? envLogLevel : defaultLogLevel;
 }
 

yarn-project/prover-client/package.json

@@ -26,7 +26,7 @@
     "formatting": "run -T prettier --check ./src && run -T eslint ./src",
     "formatting:fix": "run -T eslint --fix ./src && run -T prettier -w ./src",
     "bb": "node --no-warnings ./dest/bb/index.js",
-    "test": "LOG_LEVEL=${LOG_LEVEL:-silent} DEBUG_COLORS=1 NODE_NO_WARNINGS=1 node --experimental-vm-modules ../node_modules/.bin/jest --testTimeout=1500000 --forceExit",
+    "test": "DEBUG_COLORS=1 NODE_NO_WARNINGS=1 node --experimental-vm-modules ../node_modules/.bin/jest --testTimeout=1500000 --forceExit",
     "test:debug": "LOG_LEVEL=debug DEBUG_COLORS=1 NODE_NO_WARNINGS=1 node --experimental-vm-modules ../node_modules/.bin/jest --testTimeout=1500000 --forceExit --testNamePattern prover/bb_prover/parity"
   },
   "jest": {

yarn-project/prover-client/package.local.json

@@ -1,5 +1,5 @@
 {
   "scripts": {
-    "test": "LOG_LEVEL=${LOG_LEVEL:-silent} DEBUG_COLORS=1 NODE_NO_WARNINGS=1 node --experimental-vm-modules ../node_modules/.bin/jest --testTimeout=1500000 --forceExit"
+    "test": "DEBUG_COLORS=1 NODE_NO_WARNINGS=1 node --experimental-vm-modules ../node_modules/.bin/jest --testTimeout=1500000 --forceExit"
   }
 }