Skip to content

Commit 9b26651

Browse files
authored
fix: Bad merge on boxes (#10579)
Should fix [this error](https://github.com/AztecProtocol/aztec-packages/actions/runs/12256923180/job/34196282579#step:5:713). Note that boxes may still fail to build, there's an unrelated error on a missing artifact. Will keep looking into it.
1 parent dede16e commit 9b26651

File tree

5 files changed

+17
-20
lines changed

5 files changed

+17
-20
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ This provide an interactive environment for debugging the CI test.
4747

4848
## Debugging
4949

50-
Logging goes through the [DebugLogger](yarn-project/foundation/src/log/debug.ts) module in Typescript. `LOG_LEVEL` controls the default log level, and one can set alternate levels for specific modules, such as `debug; warn: module1, module2; error: module3`.
50+
Logging goes through the [Logger](yarn-project/foundation/src/log/) module in Typescript. `LOG_LEVEL` controls the default log level, and one can set alternate levels for specific modules, such as `debug; warn: module1, module2; error: module3`.
5151

5252
## Releases
5353

boxes/boxes/vite/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"clean": "rm -rf ./dist .tsbuildinfo ./artifacts ./src/contracts/target",
1010
"prep": "yarn clean && yarn compile && yarn codegen",
1111
"dev": "vite",
12-
"build": "tsc -b && vite build",
12+
"build": "yarn prep && tsc -b && vite build",
1313
"lint": "eslint .",
1414
"preview": "vite preview"
1515
},
@@ -45,4 +45,4 @@
4545
"vite-plugin-node-polyfills": "^0.22.0",
4646
"vite-plugin-top-level-await": "^1.4.4"
4747
}
48-
}
48+
}

boxes/boxes/vite/src/config.ts

+9-12
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import {
22
AztecNode,
33
Fr,
4-
createDebugLogger,
4+
createLogger,
55
deriveMasterIncomingViewingSecretKey,
66
} from "@aztec/aztec.js";
77
import { BoxReactContractArtifact } from "../artifacts/BoxReact";
@@ -24,10 +24,7 @@ export class PrivateEnv {
2424
accountContract;
2525
account: AccountManager;
2626

27-
constructor(
28-
private secretKey: Fr,
29-
private nodeURL: string,
30-
) {}
27+
constructor(private secretKey: Fr, private nodeURL: string) {}
3128

3229
async init() {
3330
const config = getPXEServiceConfig();
@@ -36,20 +33,20 @@ export class PrivateEnv {
3633
const proofCreator = new TestPrivateKernelProver();
3734
this.pxe = await this.createPXEService(aztecNode, config, proofCreator);
3835
const encryptionPrivateKey = deriveMasterIncomingViewingSecretKey(
39-
this.secretKey,
36+
this.secretKey
4037
);
4138
this.accountContract = new SingleKeyAccountContract(encryptionPrivateKey);
4239
this.account = new AccountManager(
4340
this.pxe,
4441
this.secretKey,
45-
this.accountContract,
42+
this.accountContract
4643
);
4744
}
4845

4946
async createPXEService(
5047
aztecNode: AztecNode,
5148
config: PXEServiceConfig,
52-
proofCreator?: PrivateKernelProver,
49+
proofCreator?: PrivateKernelProver
5350
) {
5451
const l1Contracts = await aztecNode.getL1ContractAddresses();
5552
const configWithContracts = {
@@ -60,7 +57,7 @@ export class PrivateEnv {
6057
const store = await createStore(
6158
"pxe_data",
6259
configWithContracts,
63-
createDebugLogger("aztec:pxe:data:indexeddb"),
60+
createLogger("pxe:data:indexeddb")
6461
);
6562

6663
const keyStore = new KeyStore(store);
@@ -74,7 +71,7 @@ export class PrivateEnv {
7471
db,
7572
tips,
7673
proofCreator,
77-
config,
74+
config
7875
);
7976
await server.start();
8077
return server;
@@ -88,7 +85,7 @@ export class PrivateEnv {
8885

8986
export const deployerEnv = new PrivateEnv(
9087
SECRET_KEY,
91-
process.env.PXE_URL || "http://localhost:8080",
88+
process.env.PXE_URL || "http://localhost:8080"
9289
);
9390

9491
const IGNORE_FUNCTIONS = [
@@ -97,5 +94,5 @@ const IGNORE_FUNCTIONS = [
9794
"sync_notes",
9895
];
9996
export const filteredInterface = BoxReactContractArtifact.functions.filter(
100-
(f) => !IGNORE_FUNCTIONS.includes(f.name),
97+
(f) => !IGNORE_FUNCTIONS.includes(f.name)
10198
);

boxes/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"version": "0.5.0",
55
"type": "module",
66
"scripts": {
7-
"compile": "yarn workspaces foreach -A -v run compile",
8-
"build": "yarn workspaces foreach -A -v run build",
7+
"compile": "yarn workspaces foreach --exclude vite -A -v run compile",
8+
"build": "yarn workspaces foreach --exclude vite -A -v run build",
99
"install-browsers": "playwright install --with-deps",
1010
"publish": "yarn npm publish",
1111
"test": "vitest bin.test.js",
@@ -43,4 +43,4 @@
4343
"devDependencies": {
4444
"@playwright/test": "1.46.1"
4545
}
46-
}
46+
}

docs/docs/tutorials/codealong/contract_tutorials/token_bridge/4_typescript_glue_code.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Open `cross_chain_messaging.test.ts` and paste the initial description of the te
3838

3939
```typescript
4040
import { beforeAll, describe, beforeEach, expect, jest, it} from '@jest/globals'
41-
import { AccountWallet, AztecAddress, BatchCall, type DebugLogger, EthAddress, Fr, computeAuthWitMessageHash, createLogger, createPXEClient, waitForPXE, L1ToL2Message, L1Actor, L2Actor, type PXE, type Wallet } from '@aztec/aztec.js';
41+
import { AccountWallet, AztecAddress, BatchCall, type Logger, EthAddress, Fr, computeAuthWitMessageHash, createLogger, createPXEClient, waitForPXE, L1ToL2Message, L1Actor, L2Actor, type PXE, type Wallet } from '@aztec/aztec.js';
4242
import { getInitialTestAccountsWallets } from '@aztec/accounts/testing';
4343
import { TokenContract } from '@aztec/noir-contracts.js/Token';
4444
import { sha256ToField } from '@aztec/foundation/crypto';
@@ -79,7 +79,7 @@ async function publicDeployAccounts(sender: Wallet, accountsToDeploy: Wallet[],
7979
describe('e2e_cross_chain_messaging', () => {
8080
jest.setTimeout(90_000);
8181

82-
let logger: DebugLogger;
82+
let logger: Logger;
8383
let wallets: AccountWallet[];
8484
let user1Wallet: AccountWallet;
8585
let user2Wallet: AccountWallet;

0 commit comments

Comments
 (0)