Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Buffer imports to files that use it #10477

Open
Tracked by #8881
olehmisar opened this issue Dec 7, 2024 · 1 comment
Open
Tracked by #8881

Add Buffer imports to files that use it #10477

olehmisar opened this issue Dec 7, 2024 · 1 comment
Labels
T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature).

Comments

@olehmisar
Copy link
Contributor

Buffer is node.js specific and is not supported in browsers. Right now users must polyfill Buffer in order to use @aztec/aztec.js.

Steps to fix:

  1. Remove @types/node from dependencies
  2. Add buffer to dependencies
  3. Add import { Buffer } from "buffer" in every file that uses Buffer

Optionally, replace Buffer with Uint8Array where possible: function parameters and return values, Bufferable type, etc.
@olehmisar
Copy link
Contributor Author

@rahul-kothari please track in #8881

@Maddiaa0 Maddiaa0 added the T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature). label Dec 10, 2024
@rahul-kothari rahul-kothari mentioned this issue Dec 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-feature-request Type: Adding a brand new feature (not to be confused with improving an existing feature).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olehmisar @Maddiaa0