Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Orchestrator tests explodes when gas and fees are non-zero #9900

Open
LHerskind opened this issue Nov 12, 2024 · 1 comment
Open

bug: Orchestrator tests explodes when gas and fees are non-zero #9900

LHerskind opened this issue Nov 12, 2024 · 1 comment
Labels
T-bug Type: Bug. Something is broken.

Comments

@LHerskind
Copy link
Contributor

There are a bunch of issues in the orchestrator test when you start having non-zero gas usage and prices.

As of #9868 the test a simply using 0 gas at 0 cost to avoid those pains as it worked in e2e.

However, when the values are non-zero, the output from public seems to still be 0, not taking fees or the summed into account. For private, the inclusion fee is accounted for when the header is computed in the orchestrator but not the gas. However circuits do account for them, so likely something with the mocks that are wrong.

In this slack thread is my descent into madness https://aztecprotocol.slack.com/archives/C04BTJAA694/p1731407517443459

@LHerskind LHerskind added the T-bug Type: Bug. Something is broken. label Nov 12, 2024
@LHerskind
Copy link
Contributor Author

Part of the issue might come from the following section. At least it would provide some insights into why the public behaved differently.

gas_used: Gas::empty(), // gas_used is not used in rollup circuits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-bug Type: Bug. Something is broken.
Projects
None yet
Development

No branches or pull requests

1 participant