Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: copy paste err: peer_weight vs private_ip_address_allocation #370

Closed
davidkarlsen opened this issue May 10, 2022 · 2 comments · Fixed by #375 or #377
Closed

bug: copy paste err: peer_weight vs private_ip_address_allocation #370

davidkarlsen opened this issue May 10, 2022 · 2 comments · Fixed by #375 or #377
Assignees
Labels
bug Something isn't working PR-merged
Milestone

Comments

@davidkarlsen
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Versions

2.0.1

terraform:NA

azure provider: NA

module: this

Description

Describe the bug

This seems like a copy paste error:

peer_weight = try(bgp_settings.value["private_ip_address_allocation"], null)

Steps to Reproduce

NA

Screenshots

NA
Additional context
Just browsed some code.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 10, 2022
@davidkarlsen davidkarlsen changed the title copy paste err bug: copy paste err: private_ip_address_allocation vs private_ip_address_allocation May 10, 2022
@davidkarlsen davidkarlsen changed the title bug: copy paste err: private_ip_address_allocation vs private_ip_address_allocation bug: copy paste err: peer_weight vs private_ip_address_allocation May 10, 2022
@matt-FFFFFF
Copy link
Member

Thanks @davidkarlsen for raising this - it indeed does look like a bug.

Let me look into creating a hotfix for it

@matt-FFFFFF matt-FFFFFF added the bug Something isn't working label May 11, 2022
@matt-FFFFFF matt-FFFFFF self-assigned this May 11, 2022
@ghost ghost removed the Needs: Triage 🔍 Needs triaging by the team label May 11, 2022
@matt-FFFFFF matt-FFFFFF added this to the v2.0.2 milestone May 12, 2022
@matt-FFFFFF matt-FFFFFF linked a pull request May 12, 2022 that will close this issue
@ghost ghost added the PR-referenced label May 12, 2022
@matt-FFFFFF
Copy link
Member

Hi @davidkarlsen

I have staged this change as a PR into the v2.0.2 release branch

#375

@ghost ghost added PR-merged and removed PR-referenced labels May 12, 2022
@matt-FFFFFF matt-FFFFFF mentioned this issue May 12, 2022
6 tasks
@ghost ghost added PR-referenced and removed PR-merged labels May 12, 2022
@ghost ghost added PR-merged and removed PR-referenced labels May 13, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working PR-merged
Projects
None yet
2 participants