Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep songs in correct order when downloading albums #5

Closed
atinba opened this issue Nov 10, 2024 · 2 comments
Closed

Keep songs in correct order when downloading albums #5

atinba opened this issue Nov 10, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@atinba
Copy link

atinba commented Nov 10, 2024

Is your feature request related to a problem? Please describe.
When downloading a full album, it will be nice to have the songs in correct order. We can do this by numbering the file names. For eg. the first song of the album will be "01 - .mp3" etc.

Describe the solution you'd like
An option in settings to number the file names when downloading full album.
Maybe we can only have this option when we're downloading the album in a separate folder.

Additional context
I'm currently working on this. Will create a PR when done.

@atinba atinba added the enhancement New feature or request label Nov 10, 2024
@BrightDV
Copy link
Owner

Thanks for the idea, I do agree. However, your solution might not be the best one.
I saw that the app use metadata_god where we can add the track number (of the album) at the download.

Image

Then, the sort could use this metadata, instead of the name of the file (not sure about this one).
In this way, the downloaded files would better integrate in other music players.

@BrightDV
Copy link
Owner

What you have done in your fork seems good, maybe you can open a PR.
However, as there is a huge lack of information from JioSaavn, I will sadly not work on this, as it is pretty much complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants