Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in test, unexpected use of route?.query #3486

Open
ElectricNroff opened this issue Mar 3, 2025 · 0 comments
Open

in test, unexpected use of route?.query #3486

ElectricNroff opened this issue Mar 3, 2025 · 0 comments

Comments

@ElectricNroff
Copy link

} else if (route.name != 'home' || route?.query) {

This is potentially hard to understand and maintain. If there is a chance that route might be null or undefined, then this line would need route?.name in addition to route?.query (there are no other uses of route? in the file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Triage
Development

No branches or pull requests

1 participant