Skip to content

Commit de124b6

Browse files
joehattorihdeller
authored andcommitted
fbdev: omapfb: Fix an OF node leak in dss_of_port_get_parent_device()
dss_of_port_get_parent_device() leaks an OF node reference when i >= 2 and struct device_node *np is present. Since of_get_next_parent() obtains a reference of the returned OF node, call of_node_put() before returning NULL. This was found by an experimental verifier that I am developing, and no runtime test was able to be performed due to that lack of actual devices. Fixes: f76ee89 ("omapfb: copy omapdss & displays for omapfb") Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 021e111 commit de124b6

File tree

1 file changed

+1
-0
lines changed
  • drivers/video/fbdev/omap2/omapfb/dss

1 file changed

+1
-0
lines changed

drivers/video/fbdev/omap2/omapfb/dss/dss-of.c

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ struct device_node *dss_of_port_get_parent_device(struct device_node *port)
3636
np = of_get_next_parent(np);
3737
}
3838

39+
of_node_put(np);
3940
return NULL;
4041
}
4142

0 commit comments

Comments
 (0)