Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button popup cannot open dialogue box on page in Firefox #157

Open
zhum opened this issue Oct 30, 2017 · 3 comments
Open

Button popup cannot open dialogue box on page in Firefox #157

zhum opened this issue Oct 30, 2017 · 3 comments
Assignees
Labels
br-firefox This only affects Firefox bug This is a bug with the extension pr-high This is a high-priority issue. If you want to help out, try one of these if you can!

Comments

@zhum
Copy link

zhum commented Oct 30, 2017

Note: I use localized interface, so may be menu point can ba named slightly different.
Note 2: seems to be related to BUG#153

  1. Go to any page, e.g. https://www.mendeley.com/newsfeed
  2. Click to CatBlock icon, select "Do not run on this domain pages"
  3. Reload page.

What should happen when you do the above steps

This page and all pages on this domain should be "whitelisted" and CatBlock shouldb't block any requests on them.

What actually happened?

CatBlock works as nothing happened, all block applied.

Do you have any other comments? If you can, can you please attach a screenshot of the bug?

If I manually add this domain in whetelist via Settings, all work as expected.

--- The questions below are optional but VERY helpful. ---

If unchecking all filter lists fixes the problem, which one filterlist must you check to cause the problem again after another restart?

no

Technical Chrome users: Go to chrome://extensions ->Developer Mode -> Inspect views: background page -> Console. Paste the contents here:

I use FF on Linux x86-64 (Mint 18.3)

@itskdog
Copy link
Member

itskdog commented Oct 30, 2017

Thanks for this report - I kept forgetting to make one myself!

It's not related to #153, though.

What should happen is that a box pops up allowing you to select how much of the domain you want to block, but that's not appearing at the moment.

It seems to work fine on Chrome, but I'll take a look at this.

Thanks once again!

@itskdog itskdog self-assigned this Oct 30, 2017
@itskdog itskdog added br-firefox This only affects Firefox bug This is a bug with the extension pr-high This is a high-priority issue. If you want to help out, try one of these if you can! labels Oct 30, 2017
@itskdog
Copy link
Member

itskdog commented Nov 3, 2017

Bug confirmed with latest unpublished version in Firefox Unbranded 56.

@itskdog
Copy link
Member

itskdog commented Nov 3, 2017

@tomasko126 I've tried taking a look - I'm getting an error in the background page "Can't access dead object" at js/background.js:1175. The debugger wouldn't load for me in Firefox Unbranded 56.0.2

@itskdog itskdog assigned tomasko126 and unassigned itskdog Nov 3, 2017
@itskdog itskdog changed the title "Do not run on this domain" does not wok... Button popup cannot open dialogue box on page Nov 3, 2017
@itskdog itskdog changed the title Button popup cannot open dialogue box on page Button popup cannot open dialogue box on page in Firefox Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
br-firefox This only affects Firefox bug This is a bug with the extension pr-high This is a high-priority issue. If you want to help out, try one of these if you can!
Projects
None yet
Development

No branches or pull requests

3 participants