Skip to content

Commit 2c7ff74

Browse files
jirutkaCeres6
authored andcommitted
build: compile bundled simdjson conditionally
The --shared-simdjson flag was introduced in nodejs#52924, but the implementation was incomplete. Resolves nodejs#52914 PR-URL: nodejs#55886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 6566999 commit 2c7ff74

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

node.gyp

-3
Original file line numberDiff line numberDiff line change
@@ -849,7 +849,6 @@
849849
'dependencies': [
850850
'deps/googletest/googletest.gyp:gtest_prod',
851851
'deps/histogram/histogram.gyp:histogram',
852-
'deps/simdjson/simdjson.gyp:simdjson',
853852
'deps/simdutf/simdutf.gyp:simdutf',
854853
'deps/nbytes/nbytes.gyp:nbytes',
855854
'node_js2c#host',
@@ -1171,7 +1170,6 @@
11711170
'deps/googletest/googletest.gyp:gtest',
11721171
'deps/googletest/googletest.gyp:gtest_main',
11731172
'deps/histogram/histogram.gyp:histogram',
1174-
'deps/simdjson/simdjson.gyp:simdjson',
11751173
'deps/simdutf/simdutf.gyp:simdutf',
11761174
'deps/nbytes/nbytes.gyp:nbytes',
11771175
],
@@ -1364,7 +1362,6 @@
13641362
'<(node_lib_target_name)',
13651363
'deps/histogram/histogram.gyp:histogram',
13661364
'deps/nbytes/nbytes.gyp:nbytes',
1367-
'deps/simdjson/simdjson.gyp:simdjson',
13681365
'deps/simdutf/simdutf.gyp:simdutf',
13691366
],
13701367

node.gypi

+4
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,10 @@
216216
'dependencies': [ 'deps/ada/ada.gyp:ada' ],
217217
}],
218218

219+
[ 'node_shared_simdjson=="false"', {
220+
'dependencies': [ 'deps/simdjson/simdjson.gyp:simdjson' ],
221+
}],
222+
219223
[ 'node_shared_brotli=="false"', {
220224
'dependencies': [ 'deps/brotli/brotli.gyp:brotli' ],
221225
}],

0 commit comments

Comments
 (0)