Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark: Don't manually build Lotus #143

Closed
4 tasks
LesnyRumcajs opened this issue Jul 14, 2023 · 0 comments · Fixed by #283
Closed
4 tasks

Benchmark: Don't manually build Lotus #143

LesnyRumcajs opened this issue Jul 14, 2023 · 0 comments · Fixed by #283

Comments

@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Jul 14, 2023

Issue summary

There is no need to manually build Lotus from the source unless we change some flags or node settings. We can use docker images that the Lotus team already regularly publishes.

The stable releases are available here.

For mainnet we should use stable tag, for calibnet it will be stable-calibnet. We should not use master like in the current scripts.

This should cut benchmark times, and reduce the dependencies hell (right now, if new Lotus would introduce a new dependency, the benchmarks would fail).

Acceptance criteria

  • Benchmark doesn't build Lotus, it is using Lotus docker images,
  • Lotus versions are stable, not development,
  • Dependencies are cleaned
  • Documentation (if any) is updated

Other information and links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant