Merge branch 'main' into elmattic/optional-eth-mappings

Author: elmattic

.clippy.toml

@@ -24,6 +24,22 @@ use parking_lot::Mutex instead to silently ignore panics."""
 path = "multihash_codetable::Code"
 reason = """use `crate::utils::multihash::MultihashCode` instead which has `Identity` code back-filled."""
 
+[[disallowed-types]]
+path = "rand::rngs::ThreadRng"
+reason = """use `crate::utils::forest_rng` instead."""
+
+[[disallowed-types]]
+path = "rand::rngs::OsRng"
+reason = """use `crate::utils::forest_os_rng` instead."""
+
+[[disallowed-methods]]
+path = "rand::thread_rng"
+reason = """use `crate::utils::forest_rng` instead."""
+
+[[disallowed-methods]]
+path = "uuid::Uuid::new_v4"
+reason = """use `crate::utils::new_uuid_v4` instead."""
+
 [[disallowed-methods]]
 path = "tempfile::NamedTempFile::new"
 reason = """The temporary files created by this method are not persistable if the temporary directory lives on a different filesystem than the target directory. While it is valid in other contexts (if not persisting files), it was misused many times and so we are banning it. Consider using `tempfile::NamedTempFile::new_in` or `tempfile::NamedTempFile::Builder"""

.github/DOCKER_ISSUE_TEMPLATE.md

@@ -5,6 +5,4 @@ labels: ["Bug"]
 
 ## Description
 
-Latest Docker check failed. Please check the logs for more information.
-
-<!-- link will be added here in a follow-up once the corresponding workflow lands on main -->
+Latest Docker check failed. Please [check the logs](https://github.com/ChainSafe/forest/actions/workflows/dockerfile-check.yml) for more information.

.github/SNAPSHOT_PARITY_ISSUE_TEMPLATE.md

@@ -0,0 +1,8 @@
+---
+title: "[automated] Snapshot parity test failure"
+labels: ["Bug"]
+---
+
+## Description
+
+Latest snapshot parity test failed. Please [check the logs](https://github.com/ChainSafe/forest/actions/workflows/snapshot-parity.yml) for more information.

.github/workflows/butterflynet.yml

@@ -21,7 +21,7 @@ jobs:
       - name: Checkout Sources
         uses: actions/checkout@v4
       - name: Setup sccache
-        uses: mozilla-actions/sccache-action@v0.0.7
+        uses: mozilla-actions/sccache-action@v0.0.8
         timeout-minutes: "${{ fromJSON(env.CACHE_TIMEOUT_MINUTES) }}"
         continue-on-error: true
       - uses: actions/setup-go@v5

.github/workflows/docker.yml

@@ -56,7 +56,7 @@ jobs:
       - name: Checkout Sources
         uses: actions/checkout@v4
       - name: Setup sccache
-        uses: mozilla-actions/sccache-action@v0.0.7
+        uses: mozilla-actions/sccache-action@v0.0.8
         timeout-minutes: '${{ fromJSON(env.CACHE_TIMEOUT_MINUTES) }}'
         continue-on-error: true
       - uses: actions/setup-go@v5
@@ -100,7 +100,7 @@ jobs:
         uses: actions/checkout@v4
         if: github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/v')
       - name: Setup sccache
-        uses: mozilla-actions/sccache-action@v0.0.7
+        uses: mozilla-actions/sccache-action@v0.0.8
         if: github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/v')
         timeout-minutes: '${{ fromJSON(env.CACHE_TIMEOUT_MINUTES) }}'
         continue-on-error: true

.github/workflows/forest.yml

@@ -47,7 +47,7 @@ jobs:
       - name: Checkout Sources
         uses: actions/checkout@v4
       - name: Setup sccache
-        uses: mozilla-actions/sccache-action@v0.0.7
+        uses: mozilla-actions/sccache-action@v0.0.8
         timeout-minutes: '${{ fromJSON(env.CACHE_TIMEOUT_MINUTES) }}'
         continue-on-error: true
       - uses: actions/setup-go@v5
@@ -74,7 +74,7 @@ jobs:
       - name: Checkout Sources
         uses: actions/checkout@v4
       - name: Setup sccache
-        uses: mozilla-actions/sccache-action@v0.0.7
+        uses: mozilla-actions/sccache-action@v0.0.8
         timeout-minutes: '${{ fromJSON(env.CACHE_TIMEOUT_MINUTES) }}'
         continue-on-error: true
       - uses: actions/setup-go@v5
@@ -97,7 +97,7 @@ jobs:
       - name: Checkout Sources
         uses: actions/checkout@v4
       - name: Setup sccache
-        uses: mozilla-actions/sccache-action@v0.0.7
+        uses: mozilla-actions/sccache-action@v0.0.8
         timeout-minutes: '${{ fromJSON(env.CACHE_TIMEOUT_MINUTES) }}'
         continue-on-error: true
       - name: Install Apt Dependencies
@@ -548,32 +548,6 @@ jobs:
       - name: Dump docker logs
         if: always()
         uses: jwalton/gh-docker-logs@v2
-  snapshot-parity-checks:
-    needs:
-      - build-ubuntu
-    name: Calibnet snapshot parity checks
-    runs-on: ubuntu-24.04
-    # Run the job only on main to limit the runner cost.
-    # The downside is that the offending commit can only be caught after being merged
-    # and a manual revert is required.
-    # Note that running this step on non-draft PR does not save the cost as it always re-run
-    # all the jobs when a PR is moved out of draft. Also this parity test will be stale soon
-    # once we start including the F3(fast finality) metadata in the Forest snapshots.
-    if: github.ref == 'refs/heads/main'
-    env:
-      # We use a custom Dockerfile for CI to speed up the build process.
-      FOREST_DOCKERFILE_OVERRIDE: scripts/devnet/forest_ci.dockerfile
-    steps:
-      - uses: actions/checkout@v4
-      - uses: actions/download-artifact@v4
-        with:
-          name: 'forest-${{ runner.os }}'
-      - name: Run snapshot parity tests
-        run: ./scripts/tests/snapshot_parity/setup.sh
-        timeout-minutes: '${{ fromJSON(env.SCRIPT_TIMEOUT_MINUTES) }}'
-      - name: Dump docker logs
-        if: always()
-        uses: jwalton/gh-docker-logs@v2
   # Umbrella job to aggregate all integration tests and get their status
   integration-tests-status:
     needs:

.github/workflows/rust-lint.yml

@@ -47,7 +47,7 @@ jobs:
       - name: Checkout Sources
         uses: actions/checkout@v4
       - name: Setup sccache
-        uses: mozilla-actions/sccache-action@v0.0.7
+        uses: mozilla-actions/sccache-action@v0.0.8
         timeout-minutes: ${{ fromJSON(env.CACHE_TIMEOUT_MINUTES) }}
         continue-on-error: true
       - uses: actions/setup-go@v5

.github/workflows/snapshot-parity.yml

@@ -0,0 +1,24 @@
+name: Snapshot parity test
+on:
+  workflow_dispatch:
+  schedule:
+    - cron: "0 0 * * 0" # Runs at 00:00, only on Sunday
+jobs:
+  snapshot-parity:
+    name: Snapshot parity test
+    runs-on: buildjet-4vcpu-ubuntu-2204
+    steps:
+      - name: Checkout Sources
+        uses: actions/checkout@v4
+      - name: Run snapshot parity test
+        run: ./scripts/tests/snapshot_parity/setup.sh
+        timeout-minutes: 60
+      - name: Dump docker logs
+        if: always()
+        uses: jwalton/gh-docker-logs@v2
+      - uses: JasonEtco/create-an-issue@v2
+        if: failure()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          filename: .github/SNAPSHOT_PARITY_ISSUE_TEMPLATE.md

.github/workflows/unit-tests.yml

@@ -43,7 +43,7 @@ jobs:
       - name: Checkout Sources
         uses: actions/checkout@v4
       - name: Setup sccache
-        uses: mozilla-actions/sccache-action@v0.0.7
+        uses: mozilla-actions/sccache-action@v0.0.8
         timeout-minutes: ${{ fromJSON(env.CACHE_TIMEOUT_MINUTES) }}
         continue-on-error: true
       - uses: actions/setup-go@v5
@@ -65,7 +65,7 @@ jobs:
       - name: Checkout Sources
         uses: actions/checkout@v4
       - name: Setup sccache
-        uses: mozilla-actions/sccache-action@v0.0.7
+        uses: mozilla-actions/sccache-action@v0.0.8
         timeout-minutes: ${{ fromJSON(env.CACHE_TIMEOUT_MINUTES) }}
         continue-on-error: true
       - uses: actions/setup-go@v5

CHANGELOG.md

@@ -27,6 +27,33 @@
 
 ### Breaking
 
+### Added
+
+- [#5375](https://github.com/ChainSafe/forest/issues/5375) Add an RNG wrapper that that can be overriden by a reproducible seeded RNG.
+
+- [#5386](https://github.com/ChainSafe/forest/pull/5386) Add support for the `Filecoin.EthTraceTransaction` RPC method.
+
+- [#5383](https://github.com/ChainSafe/forest/pull/5383) Add support for `Filecoin.EthGetFilterChanges` RPC method.
+
+- [#4505](https://github.com/ChainSafe/forest/issues/4505) The Ethereum RPC API indexer now runs as a background task. It is configurable in the `[fevm]` section or via the 
+  `FOREST_FEVM_ENABLE_ETH_RPC` environment variable. Moved `client.eth_mapping_ttl` to `chain_indexer.gc_retention_epochs`, which is now specified as a number of epochs.
+
+### Changed
+
+### Removed
+
+### Fixed
+
+- [#5377](https://github.com/ChainSafe/forest/pull/5377) Fix incorrect handling of `max_height` for `latest` predefined block in `Filecoin.EthGetLogs`.
+
+- [#5356](https://github.com/ChainSafe/forest/issues/5356) Fixed slow (and incorrect!) `Filecoin.EthGasPrice` RPC method. The method now returns the correct gas price of the latest tipset.
+
+## Forest v0.24.0 "Treebeard"
+
+Non-mandatory release without network upgrades. It includes a number of potentially breaking changes (see below), new RPC methods, fixes and other improvements.
+
+### Breaking
+
 - [#5236](https://github.com/ChainSafe/forest/pull/5236) Dropped support for migrating from ancient versions of Forest. The latest supported version for migration is [v0.19.2](https://github.com/ChainSafe/forest/releases/tag/v0.19.2).
 
 - [#4261](https://github.com/ChainSafe/forest/issues/4261) Remove the short flags from `forest-wallet list` and `forest-wallet balance` commands.
@@ -79,6 +106,8 @@
 
 - [#5346](https://github.com/ChainSafe/forest/pull/5346) `Filecoin.EthGetBlockReceipts` and `Filecoin.EthGetBlockReceiptsLimited` now accepts predefined block parameters on top of the block hash, e.g., `latest`, `earliest`, `pending`.
 
+- [#5324](https://github.com/ChainSafe/forest/pull/5324) Add shell completion subcommand in `forest-tool`
+
 ### Changed
 
 - [#5237](https://github.com/ChainSafe/forest/pull/5237) Stylistic changes to FIL pretty printing.
@@ -87,8 +116,7 @@
 
 - [#5332](https://github.com/ChainSafe/forest/pull/5332) Adhere to the Ethereum RPC API for `eth_call` by not requiring the `from`, `gas`, `gas_price` and `value` parameters. `data` is still required.
 
-- [#4505](https://github.com/ChainSafe/forest/issues/4505) The Ethereum RPC API indexer now runs as a background task. It is configurable in the `[fevm]` section or via the 
-  `FOREST_FEVM_ENABLE_ETH_RPC` environment variable. Moved `client.eth_mapping_ttl` to `chain_indexer.gc_retention_epochs`, which is now specified as a number of epochs.
+- [#5359](https://github.com/ChainSafe/forest/pull/5359) Eth RPC API methods' params are now all in _camelCase_. This aligns with the Ethereum RPC API. Note that this change is only for the OpenRPC documentation and does not affect the actual RPC methods which accepted correct _camelCase_ params before.
 
 ### Removed
 
@@ -111,6 +139,8 @@
 
 - [#5213](https://github.com/ChainSafe/forest/issues/5213) Fix incorrect results for the `Filecoin.EthGetLogs` RPC method on ranges that include null tipsets.
 
+- [#5357](https://github.com/ChainSafe/forest/issues/5357) Make data field in EthCallMessage optional. Affected RPC methods are `Filecoin.EthEstimateGas`(`eth_estimateGas`) and `Filecoin.EthCall`(`eth_call`)
+
 - [#5345](https://github.com/ChainSafe/forest/pull/5345) Fixed handling of odd-length hex strings in some Eth RPC methods. Now, the methods should not return error if provided with, e.g., `0x0` (which would be expanded to `0x00`).
 
 ## Forest v.0.23.3 "Plumber"