Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setChoices twice as slow than new Choices #1275

Closed
lianee opened this issue Feb 22, 2025 · 0 comments · Fixed by #1276
Closed

setChoices twice as slow than new Choices #1275

lianee opened this issue Feb 22, 2025 · 0 comments · Fixed by #1276
Labels
bug

Comments

@lianee
Copy link

lianee commented Feb 22, 2025

Describe the bug
setChoices is slower in v11 than in v10, it is faster to destroy the Choices and recreate it

To Reproduce
Steps to reproduce the behavior: jsfliddle

  1. open console to see the timings

Expected behavior
I'd expect setChoices to be at least as fast as new Choices

Choices version and bundle

  • Version: v11.0.3 choices.min.js

Additional context
Note that I always remove the child options, otherwise it's much slower (see #1204)
@lianee lianee added the bug label Feb 22, 2025
@lianee lianee changed the title setChoices twice as slow than new CHoices setChoices twice as slow than new Choices Feb 22, 2025
@Xon Xon mentioned this issue Feb 22, 2025
Merged
@Xon Xon closed this as completed in #1276 Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix v11 setChoice performance regression Choices-js/Choices
1 participant
@lianee