Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul how default speeds are defined and stored #12

Closed
originalfoo opened this issue Feb 1, 2019 · 7 comments
Closed

Overhaul how default speeds are defined and stored #12

originalfoo opened this issue Feb 1, 2019 · 7 comments
Labels
enhancement Improve existing feature obsolete Superseded by another issue SPEED LIMITS Feature: Speed limits

Comments

@originalfoo
Copy link
Member

This is a redux of VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition#131

Current default speeds UI is naff, and also seems to store in the save game rather than global default, so each new map you have to go through the pain all over again.

Some ideas mentioned in the ticket linked above, but here's another approach that could be taken:

When setting speed limits in normal way (eg. choose speed then click the road/lane on the map), have a modifier key that also sets it as default speed for the road or lane.

As a rough example (I think there are already modifier keys so might need some changes):

  • Control + Click = set speed where clicked, also set default speed
  • Shift + Control + Click = same as Ctrl+Click, but also update all roads of that type on the map to use the new speed

This would allow entire 'default speed limit' UI to be ditched.

It would also likely solve issue of networks that have mixed lane types (eg. road + monorail); the existing 'default speed' UI is a nightmare for those (see VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition#181).

And, it would allow per-lane default speed setting for a given network prefab (see VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition#81)

Having those key shortcuts would make setting default speeds nice and easy; no more searching through massive list of road prefabs trying to find the one you want to customise; just slap some road down on the map and set it's speed with the keyboard modifiers pressed.

Note: I'm not convinced there is ever a need to set different speeds for the different types of a network (ground, elevated, bridge, slope, tunnel). Well, maybe for bridge and tunnel? But definitely not elevated or slope (they should use whatever ground is set to).

As mentioned above, default speeds should be a global setting, not per-save... although, if setting the default speed is made loads quicker + easier, maybe it wouldn't be such a problem to have it per-save?

@originalfoo originalfoo changed the title Overhaul default speeds setting Overhaul how default speeds are defined Feb 1, 2019
@originalfoo
Copy link
Member Author

originalfoo commented Feb 1, 2019

Saving default speeds to global xml file would reduce chance of hitting the max storage limit in a savegame, so, yeah, probably best to save the defaults as global. VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition#160

@originalfoo
Copy link
Member Author

originalfoo commented Feb 1, 2019

According to wiki, the Shift+Click is already used, to apply speed to all segments between junctions. So maybe something like...

Basic use:

  • Click = apply to individual segment
  • Shift+Click = apply to all segments between junctions
  • Ctrl+Click = apply to entire 'named route'

Setting defaults (Alt key):

  • Alt+Click = save as default, update any roads that were using the old default speed to the new speed
  • Alt+Ctrl+Click = save as default, force all roads of this type (even customised ones) to new speed

@krzychu124 krzychu124 added the enhancement Improve existing feature label Feb 1, 2019
@originalfoo
Copy link
Member Author

Uh, so, just doing the docs for speed limit tool; current TMPE modifiers are as follows:

  • Click one or more speed icons to set their speed
  • Click+Drag along a series of segments to set their speed
  • Shift+Click to apply a speed to all road/rail segments between two junctions
    • Original docs state 'all nearby roads' but not sure if that's the case (need to test)
  • Control+Click to set speed of individual lanes

So... For setting default speeds:

  • Alt+Click = set as default speed for that prefab, and apply to all uncustomised instances of that prefab on the map
  • Alt+Control+Click = same as above but for specific lane of the prefab

@originalfoo
Copy link
Member Author

originalfoo commented Feb 4, 2019

Being able to Right Click to revert to default speed would be useful (and Control+Right Click to revert an individual lane).

Although is that reverting to the customised default or the 'design time' default?

@originalfoo
Copy link
Member Author

Documentation would look something like this:

Each type of road or rail consists of several prefabs (ground, elevated, bridge, slope and tunnel). You can set default speeds for these prefabs, for each type of road or rail, so that every time they are used they will be set to the right speed automatically.

After choosing a speed, find an instance of the prefab on the map, then:

  • Alt+Click to set the default speed for all lanes in that prefab
  • Alt+Control+Click to set the default speed for a specific lane in that prefab

For example, if you Alt+Click the bridge of a small 2-lane road to set its speed to, say, 40, all future bridges of that type of road will have a speed of 40. In addition, any existing bridges of that road will have their speed set to 40, unless they have been individually customised.

@originalfoo
Copy link
Member Author

Some discussion in original TMPE repo regarding saving default speeds to xml. General consensus was: Save to global xml; if people want per city (rare) they can just make copies of the xml and switch accordingly. VictorPhilipp/Cities-Skylines-Traffic-Manager-President-Edition#225

@originalfoo originalfoo changed the title Overhaul how default speeds are defined Overhaul how default speeds are defined and stored Feb 6, 2019
@originalfoo originalfoo added this to the UI improvements milestone Feb 11, 2019
@originalfoo
Copy link
Member Author

Superseded by issue linked below...

@originalfoo originalfoo mentioned this issue Feb 14, 2019
12 tasks
@originalfoo originalfoo added the obsolete Superseded by another issue label Feb 16, 2019
@originalfoo originalfoo added the SPEED LIMITS Feature: Speed limits label Aug 12, 2019
@originalfoo originalfoo removed this from the UI improvements milestone Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing feature obsolete Superseded by another issue SPEED LIMITS Feature: Speed limits
Projects
None yet
Development

No branches or pull requests

2 participants