Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic Light tools became unexpectedly unresponsive at specific intersection #308

Closed
AllegedlyLuca opened this issue May 8, 2019 · 4 comments
Assignees
Labels
BUG Defect detected investigating Issue currently under investigation TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc

Comments

@AllegedlyLuca
Copy link

AllegedlyLuca commented May 8, 2019

For unknown reasons two of the traffic light tools aren't working on a particular intersection in my city (add/remove light work as normal, but not timed lights or manual light operation). The tools work as-normal at other intersections.

Attached are the output_log.txt and TMPE.log. I did have a look through them, and when I attempt to add a timed light on the intersection in question I get this error:

NullReferenceException: Object reference not set to an instance of an object
  at TrafficManager.Manager.Impl.GeometryManager.MarkAsUpdated (TrafficManager.Geometry.Impl.SegmentGeometry geometry, Boolean updateNodes) [0x00000] in <filename unknown>:0 
  at TrafficManager.Manager.Impl.GeometryManager.MarkAsUpdated (TrafficManager.Geometry.Impl.NodeGeometry geometry, Boolean updateSegments) [0x00000] in <filename unknown>:0 
  at TrafficManager.Manager.Impl.TrafficLightManager.SetTrafficLight (UInt16 nodeId, Boolean flag, .NetNode& node, TrafficManager.Manager.UnableReason& reason) [0x00000] in <filename unknown>:0 
  at TrafficManager.Manager.Impl.TrafficLightManager.AddTrafficLight (UInt16 nodeId, .NetNode& node, TrafficManager.Manager.UnableReason& reason) [0x00000] in <filename unknown>:0 
  at TrafficManager.Manager.Impl.TrafficLightManager.AddTrafficLight (UInt16 nodeId, .NetNode& node) [0x00000] in <filename unknown>:0 
  at TrafficManager.TrafficLight.Data.TrafficLightSimulation+<>c.<SetUpManualTrafficLight>b__14_0 (UInt16 nId, .NetNode& node) [0x00000] in <filename unknown>:0 
  at CitiesGameBridge.Service.NetService.ProcessNode (UInt16 nodeId, .NetNode& node, GenericGameBridge.Service.NetNodeHandler handler) [0x00000] in <filename unknown>:0 
  at CitiesGameBridge.Service.NetService.ProcessNode (UInt16 nodeId, GenericGameBridge.Service.NetNodeHandler handler) [0x00000] in <filename unknown>:0 
  at TrafficManager.TrafficLight.Data.TrafficLightSimulation.SetUpManualTrafficLight () [0x00000] in <filename unknown>:0 
  at TrafficManager.Manager.Impl.TrafficLightSimulationManager.SetUpManualTrafficLight (UInt16 nodeId) [0x00000] in <filename unknown>:0 
  at TrafficManager.UI.SubTools.ManualTrafficLightsTool.OnPrimaryClickOverlay () [0x00000] in <filename unknown>:0 
  at TrafficManager.UI.TrafficManagerTool.OnToolUpdate () [0x00000] in <filename unknown>:0 
  at ToolBase.Update () [0x00000] in <filename unknown>:0 

Could not identify any errors in TMPE.log, though there were a few lines indicating inability to find a segment. They only appear a few times, and don't seem to correspond with the errors from output_log.txt that I'm aware of.

If necessary I'll provide a copy of my city too.

output_log.txt
TMPE.log

@originalfoo
Copy link
Member

originalfoo commented May 8, 2019

If necessary I'll provide a copy of my city too.

Yes, please share URL to save game.

Also, please indicate where on the map the issue occurs (eg, with screenshot or describe nearby landmarks or something)

@originalfoo originalfoo added awaiting feedback More information required BUG Defect detected labels May 8, 2019
@AllegedlyLuca
Copy link
Author

AllegedlyLuca commented May 8, 2019

City save: https://steamcommunity.com/sharedfiles/filedetails/?id=1735996460

Area where issue occurs:
image

Edit: Restarting the game appears to have ceased the issue. Still something to investigate though.

@originalfoo originalfoo removed their assignment May 14, 2019
@originalfoo originalfoo removed the awaiting feedback More information required label May 27, 2019
@VictorPhilipp VictorPhilipp self-assigned this Jun 4, 2019
@VictorPhilipp VictorPhilipp added in-progress The problem is being solved currently investigating Issue currently under investigation and removed in-progress The problem is being solved currently labels Jun 9, 2019
@VictorPhilipp
Copy link
Collaborator

VictorPhilipp commented Jun 9, 2019

  • The only chance to get a NullReferenceException in MarkAsUpdated() is when geometry is null.
  • It seems that segEndGeo is not null but segEndGeo.GetSegmentGeometry() yields null (in GeometryManager.MarkAsUpdated(NodeGeometry, bool))
    grafik
  • So, I guess the node geometry still holds a segment end geometry that points to an invalid segment

@originalfoo originalfoo added the TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc label Aug 11, 2019
@krzychu124
Copy link
Member

So many mod updates in between, don't remember any other reports. Create new if you spot something. Closing... 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Defect detected investigating Issue currently under investigation TRAFFIC LIGHTS Feature: Traffic lights - toggle, timed, etc
Projects
None yet
Development

No branches or pull requests

4 participants