Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguation of vanilla use of 'left hand drive' #581

Open
originalfoo opened this issue Nov 29, 2019 · 0 comments
Open

Disambiguation of vanilla use of 'left hand drive' #581

originalfoo opened this issue Nov 29, 2019 · 0 comments
Labels
adjustments required An issue require some adjustments in code Annoyance Not a bug, but just as annoying code cleanup Refactor code, remove old code, improve maintainability technical Tasks that need to be performed in order to improve quality and maintainability

Comments

@originalfoo
Copy link
Member

In #580, some TM:PE code was updated to replace confusingly named LeftHandDrive with unambiguous TrafficDrivesOnLeft.

For clarification:

  • LHD = left hand driver (so traffic drives on right)
  • RHD = right hand driver (so traffic drives on left)
  • LHT = left hand traffic (so driver sits on right)
  • RHT = right hand traffic (so driver sits on left)

Standard terminology is crazy confusing, hence the rename in #580.

However, there are still issues stemming from vanilla code:

@krzychu124: I will check the code later but vanilla uses that term too. There is LeftHandDrive Vehicle.Flags and LeftHandDrive method in VehicleAI and SnowTruckAI so confusion is inevitable :)

If possible, can we find a way to mask out the crappy vanilla terminology with something better? It will make the code much more comprehensible and maintainable.

@originalfoo originalfoo added Annoyance Not a bug, but just as annoying adjustments required An issue require some adjustments in code technical Tasks that need to be performed in order to improve quality and maintainability code cleanup Refactor code, remove old code, improve maintainability labels Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adjustments required An issue require some adjustments in code Annoyance Not a bug, but just as annoying code cleanup Refactor code, remove old code, improve maintainability technical Tasks that need to be performed in order to improve quality and maintainability
Projects
None yet
Development

No branches or pull requests

1 participant