Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto junction give-way/priority (on priority routes) #7

Closed
originalfoo opened this issue Feb 1, 2019 · 4 comments · Fixed by #631
Closed

Auto junction give-way/priority (on priority routes) #7

originalfoo opened this issue Feb 1, 2019 · 4 comments · Fixed by #631
Labels
enhancement Improve existing feature PRIORITY SIGNS Feature: Stop / Yield / Priority signs

Comments

@originalfoo
Copy link
Member

On a priority route (as defined via road info view panel), any junctions without traffic lights could be given automatic give-way and priority settings.

The calculations would be performed whenever user:

  • Marks or unmarks a road as 'priority route' (via road info panel)
  • Connects or disconnects a road to an existing priority route
  • Removes traffic lights at a junction that has at least one priority route attached

In cases where a junction has two or more priority routes, the primary route can be determined via metrics such as:

  • Number of lanes (more = higher priority)
  • Speed of road and/or lane (faster = higher priority)
  • Width of road and/or lane (wider = higher priority)
@krzychu124 krzychu124 added the enhancement Improve existing feature label Feb 1, 2019
@FireController1847
Copy link
Collaborator

Isn't this the purpose of adding a stop sign? I think it's a good idea for having a right of way & priority, however I don't really see the purpose of it other than to avoid putting yield/stop signs.

@originalfoo
Copy link
Member Author

In game, yes, I believe marking a route as priority will cause connecting roads to be given stop signs.

However, what I'm seeking is tighter integration between TMPE and vanilla.

So TMPE should apply it's priority/yeild signs as applicable along a priority route.

There is already TMPE option of Shift+Click when adding priority signs to apply them to all junctions for the given road (not tested this myself yet, but see docs here: https://tmpe.viathinksoft.com/wiki/index.php?title=Priority_signs#Priority_roads ).

So in theory the heavy lifting code is already done, it just needs a little extra wiring so that when user first marks a route as 'priority' (using vanilla functionality) TMPE at that point sets up the priority/yield signs. Users can subsequently go in and change any junctions as desired.

@FireController1847
Copy link
Collaborator

That's an interesting way to look at it. Awesome idea +1

@originalfoo
Copy link
Member Author

This was implemented by #631 - vanilla 'Priority road' checkbox replaced with TMPE priority toolbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing feature PRIORITY SIGNS Feature: Stop / Yield / Priority signs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants