Updated old model scopes definition

Author: abisosa

app/models/message.rb

@@ -4,7 +4,7 @@ class Message < ActiveRecord::Base
   belongs_to :service
   belongs_to :status
 
-  scope :with_status, lambda { |status_id|
+  scope :with_status,-> (status_id) {
     where(status_id: status_id)
   }
 end

app/models/service_request.rb

@@ -21,41 +21,41 @@ class ServiceRequest < ActiveRecord::Base
   mount_uploader :media, ImageUploader
   acts_as_voteable
 
-  default_scope order: 'created_at DESC'
+  default_scope { order('created_at DESC') }
 
-  scope :on_start_date, lambda {|from|
+  scope :on_start_date, -> (from) {
     where("service_requests.created_at >= ?", from) unless from.blank?
   }
 
-  scope :on_finish_date, lambda { |to|
+  scope :on_finish_date, -> (to) {
     where("service_requests.created_at <= ?", to) unless to.blank?
   }
 
-  scope :with_status, lambda { |status_id|
+  scope :with_status, -> (status_id) {
     where(status_id: status_id) unless status_id.blank?
   }
 
-  scope :on_status_name, lambda { |status_name|
+  scope :on_status_name, -> (status_name) {
     joins(:status).where('statuses.name = ?', status_name) unless status_name.blank?
   }
 
-  scope :on_service, lambda { |service_ids|
+  scope :on_service, -> (service_ids) {
     where(service_id: service_ids.split(',')) unless service_ids.blank?
   }
 
-  scope :find_by_ids, lambda { |ids|
+  scope :find_by_ids, -> (ids) {
     where("service_requests.id IN (?)", ids.split(',')) unless ids.blank?
   }
 
-  scope :closed, lambda {
+  scope :closed, -> {
     where(status_id: 4)
   }
 
-  scope :not_closed, lambda {
+  scope :not_closed, -> {
     where('status_id != ?', 4)
   }
 
-  scope :open, lambda {
+  scope :open, -> {
     where(status: 1)
   }
 

app/models/status.rb

@@ -7,7 +7,7 @@ class Status < ActiveRecord::Base
 
   before_create :set_default_if_is_the_first
 
-  default_scope order('created_at')
+  default_scope { order('created_at') }
 
   def to_s
     name

app/models/vote.rb

@@ -1,9 +1,9 @@
 class Vote < ActiveRecord::Base
 
-  scope :for_voter, lambda { |*args| where(["voter_id = ? AND voter_type = ?", args.first.id, args.first.class.base_class.name]) }
-  scope :for_voteable, lambda { |*args| where(["voteable_id = ? AND voteable_type = ?", args.first.id, args.first.class.base_class.name]) }
-  scope :recent, lambda { |*args| where(["created_at > ?", (args.first || 2.weeks.ago)]) }
-  scope :descending, order("created_at DESC")
+  scope :for_voter, -> (*args) { where(["voter_id = ? AND voter_type = ?", args.first.id, args.first.class.base_class.name]) }
+  scope :for_voteable, -> (*args) { where(["voteable_id = ? AND voteable_type = ?", args.first.id, args.first.class.base_class.name]) }
+  scope :recent, -> (*args) { where(["created_at > ?", (args.first || 2.weeks.ago)]) }
+  scope :descending, -> { order("created_at DESC") }
 
   belongs_to :voteable, :polymorphic => true
   belongs_to :voter, :polymorphic => true