Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java 17 as default to compile and run Web3Signer code #718

Closed
usmansaleem opened this issue Feb 20, 2023 · 0 comments · Fixed by #870
Closed

Use Java 17 as default to compile and run Web3Signer code #718

usmansaleem opened this issue Feb 20, 2023 · 0 comments · Fixed by #870
Labels
blocked TeamCerberus Under active development by TeamCerberus @Consensys

Comments

@usmansaleem
Copy link
Collaborator

usmansaleem commented Feb 20, 2023

Use Java 17 as default to compile and run Web3Signer code. Web3Signer uses Besu's Metrics service as a dependency which is now compiled in Java 17 and cannot be used with Web3Signer when later is compiled using Java 11.

Tasks:

  • Update gradle build file and update warning that Java 17 and upward can only be used for compilation
  • Remove jdk11 docker image and distDocker logic in gradle build file
  • consider updating signers library to build for Java 17 too (may not want to do this until Teku is Java 17 since they rely on it and may need security patches).
  • Announce in Discord and Slack plans to Java 17 for next release.
@usmansaleem usmansaleem added doc-change-required Indicates an issue or PR that requires doc to be updated TeamCerberus Under active development by TeamCerberus @Consensys labels Feb 20, 2023
@usmansaleem usmansaleem self-assigned this Apr 10, 2023
@alexandratran alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Apr 20, 2023
@siladu siladu added the blocked label Jul 24, 2023
@gfukushima gfukushima mentioned this issue Jul 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked TeamCerberus Under active development by TeamCerberus @Consensys
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants