Add show_unconfirmed param for get transactions endpoints

Author: Ouziel

counterparty-core/counterpartycore/lib/api/queries.py

@@ -385,7 +385,7 @@ def get_last_block(ledger_db):
     )
 
 
-def prepare_transactions_where(type, other_conditions=None):
+def prepare_transactions_where(type, other_conditions=None, show_unconfirmed=False):
     where = []
     type_list = type.split(",")
     for transaction_type in type_list:
@@ -397,19 +397,24 @@ def prepare_transactions_where(type, other_conditions=None):
             if other_conditions:
                 where_status.update(other_conditions)
             where.append(where_status)
+    if not show_unconfirmed:
+        for cond in where:
+            cond["confirmed"] = True
     return where
 
 
 def get_transactions(
     ledger_db,
     type: TransactionType = "all",
+    show_unconfirmed: bool = False,
     cursor: str = None,
     limit: int = 10,
     offset: int = None,
 ):
     """
     Returns the list of the last ten transactions
     :param str type: The type of the transaction to return
+    :param bool show_unconfirmed: Show unconfirmed transactions
     :param str cursor: The index of the most recent transactions to return (e.g. $LAST_TX_INDEX)
     :param int limit: The number of transactions to return (e.g. 2)
     :param int offset: The number of lines to skip before returning results (overrides the `cursor` parameter)
@@ -421,14 +426,15 @@ def get_transactions(
         last_cursor=cursor,
         limit=limit,
         offset=offset,
-        where=prepare_transactions_where(type),
+        where=prepare_transactions_where(type, show_unconfirmed=show_unconfirmed),
     )
 
 
 def get_transactions_by_block(
     ledger_db,
     block_index: int,
     type: TransactionType = "all",
+    show_unconfirmed: bool = False,
     cursor: str = None,
     limit: int = 10,
     offset: int = None,
@@ -437,6 +443,7 @@ def get_transactions_by_block(
     Returns the transactions of a block
     :param int block_index: The index of the block to return (e.g. $LAST_BLOCK_INDEX)
     :param str type: The type of the transaction to return
+    :param bool show_unconfirmed: Show unconfirmed transactions
     :param str cursor: The last transaction index to return (e.g. $LAST_TX_INDEX)
     :param int limit: The maximum number of transactions to return (e.g. 5)
     :param int offset: The number of lines to skip before returning results (overrides the `cursor` parameter)
@@ -445,7 +452,7 @@ def get_transactions_by_block(
     return select_rows(
         ledger_db,
         "transactions",
-        where=prepare_transactions_where(type, where),
+        where=prepare_transactions_where(type, where, show_unconfirmed=show_unconfirmed),
         cursor_field="tx_index",
         last_cursor=cursor,
         limit=limit,
@@ -457,6 +464,7 @@ def get_transactions_by_address(
     ledger_db,
     address: str,
     type: TransactionType = "all",
+    show_unconfirmed: bool = False,
     cursor: str = None,
     limit: int = 10,
     offset: int = None,
@@ -465,6 +473,7 @@ def get_transactions_by_address(
     Returns the transactions of an address
     :param str address: The address to return (e.g. $ADDRESS_1)
     :param str type: The type of the transaction to return
+    :param bool show_unconfirmed: Show unconfirmed transactions
     :param str cursor: The last transaction index to return (e.g. $LAST_TX_INDEX)
     :param int limit: The maximum number of transactions to return (e.g. 5)
     :param int offset: The number of lines to skip before returning results (overrides the `cursor` parameter)
@@ -473,7 +482,7 @@ def get_transactions_by_address(
     return select_rows(
         ledger_db,
         "transactions",
-        where=prepare_transactions_where(type, where),
+        where=prepare_transactions_where(type, where, show_unconfirmed=show_unconfirmed),
         cursor_field="tx_index",
         last_cursor=cursor,
         limit=limit,
@@ -485,6 +494,7 @@ def get_transactions_by_addresses(
     ledger_db,
     addresses: str,
     type: TransactionType = "all",
+    show_unconfirmed: bool = False,
     cursor: str = None,
     limit: int = 100,
     offset: int = None,
@@ -493,6 +503,7 @@ def get_transactions_by_addresses(
     Returns the transactions of a list of addresses
     :param str addresses: Comma separated list of addresses to return (e.g. $ADDRESS_1,$ADDRESS_2)
     :param str type: The type of the transaction to return
+    :param bool show_unconfirmed: Show unconfirmed transactions
     :param str cursor: The last transaction index to return (e.g. $LAST_TX_INDEX)
     :param int limit: The maximum number of transactions to return (e.g. 5)
     :param int offset: The number of lines to skip before returning results (overrides the `cursor` parameter)
@@ -501,7 +512,7 @@ def get_transactions_by_addresses(
     return select_rows(
         ledger_db,
         "transactions",
-        where=prepare_transactions_where(type, where),
+        where=prepare_transactions_where(type, where, show_unconfirmed=show_unconfirmed),
         cursor_field="tx_index",
         last_cursor=cursor,
         limit=limit,