Fix EP_INFO_CAP logic error

steven-bellock · steven-bellock · commit b6df290ec66a · 2025-03-03T09:30:26.000-08:00
Fix #2997. Signed-off-by: Steven Bellock <sbellock@nvidia.com>
diff --git a/library/spdm_requester_lib/libspdm_req_get_capabilities.c b/library/spdm_requester_lib/libspdm_req_get_capabilities.c
@@ -113,8 +113,9 @@ static bool validate_responder_capability(uint32_t capabilities_flag, uint8_t ve
                     if ((ep_info_cap == 0) || (ep_info_cap == 1)) {
                         return false;
                     }
+                } else {
+                    return false;
                 }
-                return false;
             }
         } else {
             /* If certificates or public keys are not enabled then these capabilities
diff --git a/library/spdm_responder_lib/libspdm_rsp_capabilities.c b/library/spdm_responder_lib/libspdm_rsp_capabilities.c
@@ -105,8 +105,9 @@ static bool libspdm_check_request_flag_compatibility(uint32_t capabilities_flag,
                     if ((ep_info_cap == 0) || (ep_info_cap == 1)) {
                         return false;
                     }
+                } else {
+                    return false;
                 }
-                return false;
             }
         } else {
             /* If certificates or public keys are not enabled then these capabilities

Original file line number	Diff line number	Diff line change
`@@ -113,8 +113,9 @@ static bool validate_responder_capability(uint32_t capabilities_flag, uint8_t ve`
`113`	`113`	`if ((ep_info_cap == 0) \|\| (ep_info_cap == 1)) {`
`114`	`114`	`return false;`
`115`	`115`	`}`
	`116`	`+ } else {`
	`117`	`+ return false;`
`116`	`118`	`}`
`117`		`- return false;`
`118`	`119`	`}`
`119`	`120`	`} else {`
`120`	`121`	`/* If certificates or public keys are not enabled then these capabilities`
Original file line number	Diff line number	Diff line change
`@@ -105,8 +105,9 @@ static bool libspdm_check_request_flag_compatibility(uint32_t capabilities_flag,`
`105`	`105`	`if ((ep_info_cap == 0) \|\| (ep_info_cap == 1)) {`
`106`	`106`	`return false;`
`107`	`107`	`}`
	`108`	`+ } else {`
	`109`	`+ return false;`
`108`	`110`	`}`
`109`		`- return false;`
`110`	`111`	`}`
`111`	`112`	`} else {`
`112`	`113`	`/* If certificates or public keys are not enabled then these capabilities`