Skip to content

Commit f460bde

Browse files
committed
- add webpack config
- fix lib to make compatible with webpack (relative paths) - fix syntax to eliminate mocha warnings on test
1 parent cca2840 commit f460bde

File tree

4 files changed

+42
-32
lines changed

4 files changed

+42
-32
lines changed

lib/workbook.js

+14-14
Original file line numberDiff line numberDiff line change
@@ -26,71 +26,71 @@ function XlsxStreamReaderWorkBook (options) {
2626
if (!(this instanceof XlsxStreamReaderWorkBook)) return new XlsxStreamReaderWorkBook(options)
2727

2828
Object.defineProperties(this, {
29-
'options': {
29+
options: {
3030
value: options,
3131
writable: true,
3232
enumerable: true
3333
},
34-
'write': {
34+
write: {
3535
value: function () { }
3636
},
37-
'end': {
37+
end: {
3838
value: function () { }
3939
},
40-
'workBookSharedStrings': {
40+
workBookSharedStrings: {
4141
value: [],
4242
writable: true,
4343
enumerable: false
4444
},
45-
'workBookInfo': {
45+
workBookInfo: {
4646
value: {
4747
sheetRelationships: {},
4848
sheetRelationshipsNames: {}
4949
},
5050
writable: true,
5151
enumerable: false
5252
},
53-
'parsedWorkBookInfo': {
53+
parsedWorkBookInfo: {
5454
value: false,
5555
writable: true,
5656
enumerable: false
5757
},
58-
'parsedWorkBookRels': {
58+
parsedWorkBookRels: {
5959
value: false,
6060
writable: true,
6161
enumerable: false
6262
},
63-
'parsedSharedStrings': {
63+
parsedSharedStrings: {
6464
value: false,
6565
writable: true,
6666
enumerable: false
6767
},
68-
'waitingWorkSheets': {
68+
waitingWorkSheets: {
6969
value: [],
7070
writable: true,
7171
enumerable: false
7272
},
73-
'workBookStyles': {
73+
workBookStyles: {
7474
value: [],
7575
writable: true,
7676
enumerable: false
7777
},
78-
'hasFormatCodes': {
78+
hasFormatCodes: {
7979
value: false,
8080
writable: true,
8181
enumerable: false
8282
},
83-
'formatCodes': {
83+
formatCodes: {
8484
value: {},
8585
writable: true,
8686
enumerable: false
8787
},
88-
'xfs': {
88+
xfs: {
8989
value: {},
9090
writable: true,
9191
enumerable: false
9292
},
93-
'abortBook': {
93+
abortBook: {
9494
value: false,
9595
writable: true
9696
}

lib/worksheet.js

+15-15
Original file line numberDiff line numberDiff line change
@@ -18,55 +18,55 @@ function XlsxStreamReaderWorkSheet (workBook, sheetName, workSheetId, workSheetS
1818
if (!(this instanceof XlsxStreamReaderWorkSheet)) return new XlsxStreamReaderWorkSheet(workBook, sheetName, workSheetId, workSheetStream)
1919

2020
Object.defineProperties(this, {
21-
'id': {
21+
id: {
2222
value: workSheetId,
2323
enumerable: true
2424
},
25-
'workBook': {
25+
workBook: {
2626
value: workBook
2727
},
28-
'name': {
28+
name: {
2929
value: sheetName,
3030
enumerable: true
3131
},
32-
'options': {
32+
options: {
3333
value: workBook.options,
3434
writable: true,
3535
enumerable: true
3636
},
37-
'workSheetStream': {
37+
workSheetStream: {
3838
value: workSheetStream
3939
},
40-
'write': {
40+
write: {
4141
value: function () { }
4242
},
43-
'end': {
43+
end: {
4444
value: function () { }
4545
},
46-
'rowCount': {
46+
rowCount: {
4747
value: 0,
4848
enumerable: true,
4949
writable: true
5050
},
51-
'sheetData': {
51+
sheetData: {
5252
value: {},
5353
enumerable: true,
5454
writable: true
5555
},
56-
'inRows': {
56+
inRows: {
5757
value: false,
5858
writable: true
5959
},
60-
'workingRow': {
60+
workingRow: {
6161
value: {},
6262
writable: true
6363
},
64-
'currentCell': {
64+
currentCell: {
6565
value: {},
6666
enumerable: true,
6767
writable: true
6868
},
69-
'abortSheet': {
69+
abortSheet: {
7070
value: false,
7171
writable: true
7272
}
@@ -145,7 +145,7 @@ XlsxStreamReaderWorkSheet.prototype._handleWorkSheetNode = function (nodeData) {
145145
return
146146
}
147147

148-
self.sheetData['cols'] = []
148+
self.sheetData.cols = []
149149

150150
if (nodeData.length > 1 && nodeData[0].name === 'worksheet') {
151151
nodeData.shift()
@@ -173,7 +173,7 @@ XlsxStreamReaderWorkSheet.prototype._handleWorkSheetNode = function (nodeData) {
173173

174174
case 'col':
175175
delete (nodeData[0].name)
176-
self.sheetData['cols'].push(nodeData[0])
176+
self.sheetData.cols.push(nodeData[0])
177177
return
178178

179179
case 'sheetData':

lib/xlsx-stream-reader.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66

77
'use strict'
88

9-
const Path = require('path')
10-
11-
const XlsxStreamReaderWorkBook = require(Path.join(__dirname, 'workbook'))
9+
const XlsxStreamReaderWorkBook = require('./workbook')
1210

1311
module.exports = XlsxStreamReader
1412

webpack.config.js

+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
module.exports = {
2+
entry: './index.js',
3+
node: {
4+
global: true
5+
},
6+
externals: {
7+
fs: require('fs')
8+
},
9+
output: {
10+
filename: 'xlsx-stream-reader.bundle.js'
11+
}
12+
};

0 commit comments

Comments
 (0)