Skip to content

Commit b6e8358

Browse files
authored
[ASM]Fix appsec waf benchmark for real (#6329)
## Summary of changes Don't throw when creating a trace context and an empty datadog tracer ## Reason for change It [was throwing](https://datadoghq.atlassian.net/browse/APMAPI-893) when creating the context. ## Implementation details ## Test coverage ## Other details <!-- Fixes #{issue} --> <!-- ⚠️ Note: where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. -->
1 parent 615e9e2 commit b6e8358

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tracer/test/benchmarks/Benchmarks.Trace/Asm/EmptyDatadogTracer.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ public class EmptyDatadogTracer : IDatadogTracer
1919
{
2020
public string DefaultServiceName => "My Service Name";
2121

22-
public ImmutableTracerSettings Settings => throw new NotImplementedException();
22+
public ImmutableTracerSettings Settings => new(new NullConfigurationSource());
2323

24-
IGitMetadataTagsProvider IDatadogTracer.GitMetadataTagsProvider => throw new NotImplementedException();
24+
IGitMetadataTagsProvider IDatadogTracer.GitMetadataTagsProvider => new NullGitMetadataProvider();
2525

26-
PerTraceSettings IDatadogTracer.PerTraceSettings => throw new NotImplementedException();
26+
PerTraceSettings IDatadogTracer.PerTraceSettings => null;
2727

2828
void IDatadogTracer.Write(ArraySegment<Span> span)
2929
{
30-
throw new NotImplementedException();
30+
3131
}
3232
}
3333
}

0 commit comments

Comments
 (0)