Skip to content

Commit c151034

Browse files
authored
Don't run integration tests on netcoreapp2.1 (#6560)
## Summary of changes Disables the `netcoreapp2.1` integration tests ## Reason for change #6498 broke the .NET Core 2.1 integration tests, due to a strange "missing dependency" issue. I believe this is due to the somewhat frankenstein approach we have to building and restoring right now. I hope to improve this in the near future, but fixing it for 2.1 right now is too big of a cost. ## Implementation details Remove 2.1 from the tests ## Test coverage A lot less now unfortunately, but it's not "supported" anyway ## Other details This is the quickest, easiest, way to remove the 2.1 tests to fix the build. Later we can decide if this is the permanent solution we want (in which case we can stop _building_ for 2.1 too) or if we want/can reenable some of the basic tests at least.
1 parent cc4b593 commit c151034

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

tracer/build/_build/Build.Steps.cs

+2-1
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,8 @@ Project[] ClrProfilerIntegrationTests
182182

183183
TargetFramework[] GetTestingFrameworks(bool isArm64) => (isArm64, IncludeAllTestFrameworks || RequiresThoroughTesting()) switch
184184
{
185-
(false, true) => new[] { TargetFramework.NET462, TargetFramework.NETCOREAPP2_1, TargetFramework.NETCOREAPP3_0, TargetFramework.NETCOREAPP3_1, TargetFramework.NET5_0, TargetFramework.NET6_0, TargetFramework.NET7_0, TargetFramework.NET8_0, TargetFramework.NET9_0, },
185+
// Don't test 2.1 for now, as the build is broken on master. If/when that's resolved, re-enable
186+
(false, true) => new[] { TargetFramework.NET462, TargetFramework.NETCOREAPP3_0, TargetFramework.NETCOREAPP3_1, TargetFramework.NET5_0, TargetFramework.NET6_0, TargetFramework.NET7_0, TargetFramework.NET8_0, TargetFramework.NET9_0, },
186187
(false, false) => new[] { TargetFramework.NET462, TargetFramework.NETCOREAPP3_1, TargetFramework.NET8_0, TargetFramework.NET9_0, },
187188
// we only support linux-arm64 on .NET 5+, so we run a different subset of the TFMs for ARM64
188189
(true, true) => new[] { TargetFramework.NET5_0, TargetFramework.NET6_0, TargetFramework.NET7_0, TargetFramework.NET8_0, TargetFramework.NET9_0, },

0 commit comments

Comments
 (0)