[BUG]: 3.11.0+ unconditionally overwrites NoWarn settings via Datadog.Trace.props

[medianick]

Tracer Version(s)

3.11.1

Operating system and platform

Windows (x64), Amazon Linux 2023

Instrumentation Mode

Manual with NuGet package

TFM

net8.0

Bug Report

The Datadog.Trace 3.11.0 release introduced a new Datadog.Trace.props file that unconditionally overwrites the NoWarn property (see https://github.com/DataDog/dd-trace-dotnet/blob/master/tracer/src/Datadog.Trace.Manual/Datadog.Trace.props#L12 from #6678). This means that other projects that reference Datadog.Trace but define their own NoWarn property will have that overwritten, and only the two warnings Datadog.Trace now ignores (IL2007 and IL2008) will be ignored.

This should include $(NoWarn) so that any existing values of that property are carried over, e.g.:

<NoWarn>$(NoWarn);IL2007;IL2008</NoWarn>

Reproduction Code

Reference Datadog.Trace 3.11.0 or 3.11.1 in a project that specifies its own NoWarn values (e.g., CS1591) and verify that warnings are still issued for that category (e.g., through lacking documentation on public members) despite this setting.

[bouwkast]

Thanks @medianick, I've opened a PR to fix this

[medianick]

Thanks @bouwkast! Could you give me a sense of timing for the release that would include this fix (probably 3.11.2 or similar)?

[bouwkast]

Hi @medianick, we've just released version 3.12.0 which includes the above PR that should fix this issue

https://www.nuget.org/packages/Datadog.Trace/3.12.0

and

https://github.com/DataDog/dd-trace-dotnet/releases/tag/v3.12.0