use default args to report init

Author: IlyasShabi

packages/dd-trace/src/appsec/reporter.js

@@ -88,7 +88,7 @@ function formatHeaderName (name) {
     .toLowerCase()
 }
 
-function reportWafInit (wafVersion, rulesVersion, diagnosticsRules, success) {
+function reportWafInit (wafVersion, rulesVersion, diagnosticsRules = {}, success = false) {
   if (success) {
     metricsQueue.set('_dd.appsec.waf.version', wafVersion)
 

packages/dd-trace/src/appsec/waf/waf_manager.js

@@ -26,7 +26,7 @@ class WAFManager {
       return new DDWAF(rules, { obfuscatorKeyRegex, obfuscatorValueRegex })
     } catch (err) {
       this.ddwafVersion = this.ddwafVersion || 'unknown'
-      Reporter.reportWafInit(this.ddwafVersion, 'unknown', {}, false)
+      Reporter.reportWafInit(this.ddwafVersion, 'unknown')
 
       log.error('[ASM] AppSec could not load native package. In-app WAF features will not be available.')
 

packages/dd-trace/test/appsec/waf/index.spec.js

@@ -89,12 +89,7 @@ describe('WAF Manager', () => {
         expect.fail('waf init should have thrown an error')
       } catch (err) {
         expect(err).to.equal(error)
-        expect(Reporter.reportWafInit).to.have.been.calledWith(
-          '1.2.3',
-          'unknown',
-          {},
-          false
-        )
+        expect(Reporter.reportWafInit).to.have.been.calledWith('1.2.3', 'unknown')
       }
     })