Skip to content

Commit 3abdfe9

Browse files
author
Stephen Belanger
committed
Make trace done callback return value void
1 parent 0547232 commit 3abdfe9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

docs/test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ tracer.trace('test', { service: 'foo', resource: 'bar', type: 'baz' }, () => {})
372372
tracer.trace('test', { measured: true }, () => {})
373373
tracer.trace('test', (span: Span) => {})
374374
tracer.trace('test', (span: Span, fn: () => void) => {})
375-
tracer.trace('test', (span: Span, fn: (err: Error) => string) => {})
375+
tracer.trace('test', (span: Span, fn: (err: Error) => void) => {})
376376

377377
promise = tracer.trace('test', () => Promise.resolve())
378378

index.d.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,8 @@ export declare interface Tracer extends opentracing.Tracer {
8484
* option is deprecated and has been removed in version 4.0.
8585
*/
8686
trace<T> (name: string, fn: (span: Span) => T): T;
87-
trace<T> (name: string, fn: (span: Span, done: (error?: Error) => string) => T): T;
88-
trace<T> (name: string, options: TraceOptions & SpanOptions, fn: (span?: Span, done?: (error?: Error) => string) => T): T;
87+
trace<T> (name: string, fn: (span: Span, done: (error?: Error) => void) => T): T;
88+
trace<T> (name: string, options: TraceOptions & SpanOptions, fn: (span?: Span, done?: (error?: Error) => void) => T): T;
8989

9090
/**
9191
* Wrap a function to automatically create a span activated on its

0 commit comments

Comments
 (0)