do not report ecent rules when success fails

Author: IlyasShabi

packages/dd-trace/src/appsec/reporter.js

@@ -89,12 +89,14 @@ function formatHeaderName (name) {
 }
 
 function reportWafInit (wafVersion, rulesVersion, diagnosticsRules = {}, success) {
-  metricsQueue.set('_dd.appsec.waf.version', wafVersion)
+  if (success) {
+    metricsQueue.set('_dd.appsec.waf.version', wafVersion)
 
-  metricsQueue.set('_dd.appsec.event_rules.loaded', diagnosticsRules.loaded?.length || 0)
-  metricsQueue.set('_dd.appsec.event_rules.error_count', diagnosticsRules.failed?.length || 0)
-  if (diagnosticsRules.failed?.length) {
-    metricsQueue.set('_dd.appsec.event_rules.errors', JSON.stringify(diagnosticsRules.errors))
+    metricsQueue.set('_dd.appsec.event_rules.loaded', diagnosticsRules.loaded?.length || 0)
+    metricsQueue.set('_dd.appsec.event_rules.error_count', diagnosticsRules.failed?.length || 0)
+    if (diagnosticsRules.failed?.length) {
+      metricsQueue.set('_dd.appsec.event_rules.errors', JSON.stringify(diagnosticsRules.errors))
+    }
   }
 
   incrementWafInitMetric(wafVersion, rulesVersion, success)

packages/dd-trace/test/appsec/reporter.spec.js

@@ -101,7 +101,7 @@ describe('reporter', () => {
     }
 
     it('should add some entries to metricsQueue', () => {
-      Reporter.reportWafInit(wafVersion, rulesVersion, diagnosticsRules)
+      Reporter.reportWafInit(wafVersion, rulesVersion, diagnosticsRules, true)
 
       expect(Reporter.metricsQueue.get('_dd.appsec.waf.version')).to.be.eq(wafVersion)
       expect(Reporter.metricsQueue.get('_dd.appsec.event_rules.loaded')).to.be.eq(3)
@@ -110,6 +110,15 @@ describe('reporter', () => {
         .to.be.eq(JSON.stringify(diagnosticsRules.errors))
     })
 
+    it('should not add entries to metricsQueue with success false', () => {
+      Reporter.reportWafInit(wafVersion, rulesVersion, diagnosticsRules, false)
+
+      expect(Reporter.metricsQueue.get('_dd.appsec.waf.version')).to.be.undefined
+      expect(Reporter.metricsQueue.get('_dd.appsec.event_rules.loaded')).to.be.undefined
+      expect(Reporter.metricsQueue.get('_dd.appsec.event_rules.error_count')).to.be.undefined
+      expect(Reporter.metricsQueue.get('_dd.appsec.event_rules.errors')).to.be.undefined
+    })
+
     it('should call incrementWafInitMetric', () => {
       Reporter.reportWafInit(wafVersion, rulesVersion, diagnosticsRules, true)