Skip to content

Commit 538d204

Browse files
committed
fix http and restify
1 parent 770db18 commit 538d204

File tree

1 file changed

+14
-7
lines changed

1 file changed

+14
-7
lines changed

packages/dd-trace/src/format.js

+14-7
Original file line numberDiff line numberDiff line change
@@ -106,20 +106,15 @@ function extractTags (trace, span) {
106106
registerExtraService(tags['service.name'])
107107
}
108108

109+
extractHttpResource(trace, tags)
110+
109111
for (const tag in tags) {
110112
switch (tag) {
111113
case 'service.name':
112114
case 'span.type':
113115
case 'resource.name':
114116
addTag(trace, {}, map[tag], tags[tag])
115117
break
116-
case 'http.route': {
117-
const resource = [tags['http.method'], tags['http.route']].filter(v => v).join(' ')
118-
if (!tags['resource.name']) {
119-
addTag(trace, {}, 'resource', resource)
120-
}
121-
break
122-
}
123118
// HACK: remove when Datadog supports numeric status code
124119
case 'http.status_code':
125120
addTag(trace.meta, {}, tag, tags[tag] && String(tags[tag]))
@@ -196,6 +191,18 @@ function extractError (trace, error) {
196191
}
197192
}
198193

194+
function extractHttpResource (trace, tags) {
195+
if (tags['resource.name']) return
196+
if (tags['http.route']) {
197+
addTag(trace, {}, 'resource', [
198+
tags['http.method'],
199+
tags['http.route']
200+
].filter(v => v).join(' '))
201+
} else if (tags['http.method']) {
202+
addTag(trace, {}, 'resource', tags['http.method'])
203+
}
204+
}
205+
199206
function addTag (meta, metrics, key, value, nested) {
200207
switch (typeof value) {
201208
case 'string':

0 commit comments

Comments
 (0)