Skip to content

Commit 607bb95

Browse files
committed
service name delegate
1 parent a4dee82 commit 607bb95

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

packages/datadog-plugin-mongoose/test/index.spec.js

+4-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const id = require('../../dd-trace/src/id')
77

88
describe('Plugin', () => {
99
let tracer
10-
const dbName = id().toString()
10+
let dbName
1111

1212
describe('mongoose', () => {
1313
withVersions('mongoose', ['mongoose'], (version) => {
@@ -37,6 +37,8 @@ describe('Plugin', () => {
3737

3838
mongoose = require(`../../../versions/mongoose@${version}`).get()
3939

40+
dbName = id().toString()
41+
4042
connect()
4143
})
4244

@@ -55,7 +57,7 @@ describe('Plugin', () => {
5557
const PeerCat = mongoose.model('PeerCat', { name: String })
5658
new PeerCat({ name: 'PeerCat' }).save().catch(done)
5759
},
58-
dbName, 'peer.service')
60+
() => dbName, 'peer.service')
5961

6062
it('should propagate context with write operations', () => {
6163
const Cat = mongoose.model('Cat1', { name: String })

packages/dd-trace/test/setup/mocha.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ function withPeerService (tracer, pluginName, spanGenerationFn, service, service
131131
agent
132132
.use(traces => {
133133
const span = traces[0][0]
134-
expect(span.meta).to.have.property('peer.service', service)
134+
expect(span.meta).to.have.property('peer.service', typeof service === 'function' ? service() : service)
135135
expect(span.meta).to.have.property('_dd.peer.service.source', serviceSource)
136136
})
137137
.then(done)

0 commit comments

Comments
 (0)