Skip to content

Commit 65a96d3

Browse files
committed
Code hotspots and endpoint collection now enabled by default
1 parent cfc2436 commit 65a96d3

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

packages/dd-trace/src/profiling/config.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ class Config {
9797
this.debugSourceMaps = isTrue(coalesce(options.debugSourceMaps, DD_PROFILING_DEBUG_SOURCE_MAPS, false))
9898
this.endpointCollectionEnabled = isTrue(coalesce(options.endpointCollection,
9999
DD_PROFILING_ENDPOINT_COLLECTION_ENABLED,
100-
DD_PROFILING_EXPERIMENTAL_ENDPOINT_COLLECTION_ENABLED, false))
100+
DD_PROFILING_EXPERIMENTAL_ENDPOINT_COLLECTION_ENABLED, true))
101101
logExperimentalVarDeprecation('ENDPOINT_COLLECTION_ENABLED')
102102

103103
this.pprofPrefix = pprofPrefix
@@ -147,7 +147,7 @@ class Config {
147147

148148
this.codeHotspotsEnabled = isTrue(coalesce(options.codeHotspotsEnabled,
149149
DD_PROFILING_CODEHOTSPOTS_ENABLED,
150-
DD_PROFILING_EXPERIMENTAL_CODEHOTSPOTS_ENABLED, false))
150+
DD_PROFILING_EXPERIMENTAL_CODEHOTSPOTS_ENABLED, true))
151151
logExperimentalVarDeprecation('CODEHOTSPOTS_ENABLED')
152152

153153
this.profilers = ensureProfilers(profilers, this)

packages/dd-trace/test/profiling/config.spec.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ describe('config', () => {
4848
expect(config.logger).to.be.an.instanceof(ConsoleLogger)
4949
expect(config.exporters[0]).to.be.an.instanceof(AgentExporter)
5050
expect(config.profilers[0]).to.be.an.instanceof(WallProfiler)
51-
expect(config.profilers[0].codeHotspotsEnabled()).false
51+
expect(config.profilers[0].codeHotspotsEnabled()).true
5252
expect(config.profilers[1]).to.be.an.instanceof(SpaceProfiler)
5353
expect(config.v8ProfilerBugWorkaroundEnabled).true
5454
})
@@ -129,7 +129,6 @@ describe('config', () => {
129129
it('should support profiler config with DD_PROFILING_PROFILERS', () => {
130130
process.env = {
131131
DD_PROFILING_PROFILERS: 'wall',
132-
DD_PROFILING_CODEHOTSPOTS_ENABLED: '1',
133132
DD_PROFILING_V8_PROFILER_BUG_WORKAROUND: '0'
134133
}
135134
const options = {

0 commit comments

Comments
 (0)