Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: 5.41.1 caused a substantial increase in number of increment counters. #5405

Open
howinator opened this issue Mar 12, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@howinator
Copy link

howinator commented Mar 12, 2025

Tracer Version(s)

5.41.1

Node.js Version(s)

22.14

Bug Report

Upgrading 5.41.1 to broke a number of our metrics. We're having a hard time tracking down exactly what happened, but something in 5.41.1 definitely caused some of our counter metrics to increase by an order of magnitude.

In the chart below, we deployed a PR where the only substantive change was upgrading from 5.40.0 to 5.41.1.

We're currently downgrading the version to confirm this is the cause.

Perhaps related, our count metrics in Datadog are now type=gauge.

Image

Reproduction Code

This is our code to increment a metric.

export type MetricTags = Partial<Record<MetricTag, string | number>>;

export function increment(
  namespace: MetricNamespace,
  metric: MetricName,
  amount: number,
  tags?: MetricTags, // Accept string | undefined to make it easier for the client
) {
  ddTracer.dogstatsd.increment(getStat(namespace, metric), amount, tags);
}

Error Logs

No response

Tracer Config

No response

Operating System

No response

Bundling

Unsure

@howinator howinator added the bug Something isn't working label Mar 12, 2025
@howinator howinator changed the title [BUG]: [BUG]: 5.41.1 caused a substantial increase in number of increment counters. Mar 12, 2025
@howinator
Copy link
Author

I'll let you all debug, but #5347 looks like it may result in the behavior we're seeing

@alexbidule
Copy link

The same issues was observed in our application. Rolling back to 5.41.0 fixed the issue. So there must be something wrong in 5.41.1.

@MMShep97
Copy link

previous 2 issues are related:

#5389
#5394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants