From 9c296b1744f7d4370841fef565ee780c8b15c28c Mon Sep 17 00:00:00 2001 From: Juan Fernandez Date: Wed, 19 Mar 2025 10:58:52 +0100 Subject: [PATCH 1/2] increase timeout installation --- integration-tests/playwright/playwright.spec.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/integration-tests/playwright/playwright.spec.js b/integration-tests/playwright/playwright.spec.js index 7dfb3ee3fe6..cd1fd18f04b 100644 --- a/integration-tests/playwright/playwright.spec.js +++ b/integration-tests/playwright/playwright.spec.js @@ -47,11 +47,11 @@ versions.forEach((version) => { let sandbox, cwd, receiver, childProcess, webAppPort before(async function () { - // bump from 30 to 60 seconds because playwright dependencies are heavy - this.timeout(60000) + // bump from 60 to 90 seconds because we also need to download chromium + this.timeout(90000) sandbox = await createSandbox([`@playwright/test@${version}`, 'typescript'], true) cwd = sandbox.folder - // install necessary browser + // Install chromium (configured in integration-tests/playwright.config.js) const { NODE_OPTIONS, ...restOfEnv } = process.env execSync('npx playwright install', { cwd, env: restOfEnv }) webAppPort = await getPort() From 028628c2f3dfff8990399ec8c8292e991285f54e Mon Sep 17 00:00:00 2001 From: Juan Fernandez Date: Wed, 19 Mar 2025 12:33:43 +0100 Subject: [PATCH 2/2] improvements --- integration-tests/playwright/playwright.spec.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/integration-tests/playwright/playwright.spec.js b/integration-tests/playwright/playwright.spec.js index cd1fd18f04b..69bd83ca123 100644 --- a/integration-tests/playwright/playwright.spec.js +++ b/integration-tests/playwright/playwright.spec.js @@ -47,12 +47,14 @@ versions.forEach((version) => { let sandbox, cwd, receiver, childProcess, webAppPort before(async function () { - // bump from 60 to 90 seconds because we also need to download chromium + // bump from 60 to 90 seconds because we also need to install dependencies and download chromium this.timeout(90000) sandbox = await createSandbox([`@playwright/test@${version}`, 'typescript'], true) cwd = sandbox.folder - // Install chromium (configured in integration-tests/playwright.config.js) const { NODE_OPTIONS, ...restOfEnv } = process.env + // Install system dependencies + execSync('npx playwright install-deps', { cwd, env: restOfEnv }) + // Install chromium (configured in integration-tests/playwright.config.js) execSync('npx playwright install', { cwd, env: restOfEnv }) webAppPort = await getPort() webAppServer.listen(webAppPort)