Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add calibrated deposition attribute #63

Open
francois-drielsma opened this issue Feb 27, 2025 · 0 comments
Open

[FR] Add calibrated deposition attribute #63

francois-drielsma opened this issue Feb 27, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@francois-drielsma
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The issue currently is then when calibration are applied to the charge depositions, it overwrites these depositions with calibrated values such that the calibration cannot be changed/reapplied later.

Describe the solution you'd like
The solution to this is to add a depositions_calib attribute to the reconstructed objects so that the original depositions are always preserved as is. The challenge will be to propagate this change to other post-processors which expect calibrated values to function (e.g. calorimetric energy reconstruction, template-based PID, etc.).

@francois-drielsma francois-drielsma added the enhancement New feature or request label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant