feat(composables): add onlyAvailable parameter #1378

mkucmus · 2021-02-22T11:04:52Z

Checklist

the list of features is updated (if it's a feature and it's relevant)
I followed contributing guidelines

…nd shipping methods

vercel · 2021-02-22T11:04:54Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/3rnrhnkgTcJrsYiv5UGZ48wQMSHy
✅ Preview: https://shopware-pwa-d-git-feat-list-only-available-shipping-and-c64e35.vercel.app

…ent-methods-#1375

…1375' of github.com:vuestorefront/shopware-pwa into feat/list-only-available-shipping-and-payment-methods-#1375

github-actions · 2021-02-24T09:53:55Z

💙 shopware-pwa-canary successfully deployed at https://ba2b5814ff99852a1aaaa1e84d9b260069df999f.shopware-pwa-canary.preview.storefrontcloud.io

patzick

Looks good, we should add more specific typing though :)

patzick · 2021-03-01T12:41:03Z

packages/shopware-6-client/src/services/contextService.ts

@@ -159,10 +159,14 @@ export async function getAvailableSalutations(
 * @beta
 */
 export async function getAvailablePaymentMethods(
-  contextInstance: ShopwareApiInstance = defaultInstance
+  contextInstance: ShopwareApiInstance = defaultInstance,
+  params: any = {}


Suggested change

params: any = {}

params: { onlyAvailable?: boolean } = {}

patzick · 2021-03-01T12:42:44Z

packages/shopware-6-client/src/services/contextService.ts

-    getContextPaymentMethodEndpoint()
+    getContextPaymentMethodEndpoint(),
+    {
+      params, // passing it as a last parameter won't cause a BC - to consider


is this comment necessary? There shouldn't be any BC here :)

yes, removed

patzick · 2021-03-01T12:43:13Z

packages/shopware-6-client/src/services/contextService.ts

@@ -202,10 +206,14 @@ export async function setCurrentPaymentMethod(
 * @beta
 */
 export async function getAvailableShippingMethods(
-  contextInstance: ShopwareApiInstance = defaultInstance
+  contextInstance: ShopwareApiInstance = defaultInstance,
+  params: any = {} // passing it as a last parameter won't cause a BC - to consider


Suggested change

params: any = {} // passing it as a last parameter won't cause a BC - to consider

params: { onlyAvailable?: boolean } = {}

cool, thanks! added a more detailed type

patzick · 2021-03-01T12:43:54Z

api/shopware-6-client.api.md

@@ -165,13 +165,13 @@ export function getAvailableCurrencies(contextInstance?: ShopwareApiInstance): P
 export function getAvailableLanguages(contextInstance?: ShopwareApiInstance): Promise<Language[]>;

 // @beta (undocumented)
-export function getAvailablePaymentMethods(contextInstance?: ShopwareApiInstance): Promise<PaymentMethod[]>;
+export function getAvailablePaymentMethods(contextInstance?: ShopwareApiInstance, params?: any): Promise<PaymentMethod[]>;


types should change here, after local rebuild

…ent-methods-#1375

patzick

👌 excellent

vercel bot temporarily deployed to preview February 24, 2021 09:30 Inactive

mkucmus added 2 commits February 24, 2021 10:39

docs(client): type definitions

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

38843e2

vercel bot temporarily deployed to preview February 24, 2021 09:40 Inactive

patzick suggested changes Mar 1, 2021

View reviewed changes

fix: changes after CR

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

9579038

vercel bot temporarily deployed to preview March 4, 2021 14:03 Inactive

mkucmus requested a review from patzick March 4, 2021 14:04

vercel bot temporarily deployed to preview March 4, 2021 22:24 Inactive

patzick approved these changes Mar 5, 2021

View reviewed changes

patzick merged commit f0b8016 into master Mar 5, 2021

patzick deleted the feat/list-only-available-shipping-and-payment-methods-#1375 branch March 5, 2021 08:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(composables): add onlyAvailable parameter #1378

feat(composables): add onlyAvailable parameter #1378

mkucmus commented Feb 22, 2021

vercel bot commented Feb 22, 2021 •

edited

Loading

github-actions bot commented Feb 24, 2021 •

edited

Loading

patzick left a comment

patzick Mar 1, 2021

mkucmus Mar 4, 2021

patzick Mar 1, 2021

mkucmus Mar 4, 2021

patzick Mar 1, 2021

mkucmus Mar 4, 2021

patzick Mar 1, 2021

patzick left a comment

	params: any = {} // passing it as a last parameter won't cause a BC - to consider
	params: { onlyAvailable?: boolean } = {}

feat(composables): add onlyAvailable parameter #1378

feat(composables): add onlyAvailable parameter #1378

Conversation

mkucmus commented Feb 22, 2021

Checklist

vercel bot commented Feb 22, 2021 • edited Loading

github-actions bot commented Feb 24, 2021 • edited Loading

patzick left a comment

Choose a reason for hiding this comment

patzick Mar 1, 2021

Choose a reason for hiding this comment

mkucmus Mar 4, 2021

Choose a reason for hiding this comment

patzick Mar 1, 2021

Choose a reason for hiding this comment

mkucmus Mar 4, 2021

Choose a reason for hiding this comment

patzick Mar 1, 2021

Choose a reason for hiding this comment

mkucmus Mar 4, 2021

Choose a reason for hiding this comment

patzick Mar 1, 2021

Choose a reason for hiding this comment

patzick left a comment

Choose a reason for hiding this comment

vercel bot commented Feb 22, 2021 •

edited

Loading

github-actions bot commented Feb 24, 2021 •

edited

Loading