Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

test: image sizing PoC #1427

Merged
merged 38 commits into from
May 14, 2021
Merged

test: image sizing PoC #1427

merged 38 commits into from
May 14, 2021

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Apr 14, 2021

Changes

  • removed unused image files from default-theme
  • added getResizedImage method, which allows to modify URL of the image before fetching it from the server

Results (before/after):

homepage

image
image

kids category

image
image

search

image
image

cart

image
image

product page

image
image

@vercel
Copy link

vercel bot commented Apr 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/AWZGrqNuThcPwc13ijzQXUAMTXL2
✅ Preview: https://shopware-pwa-docs-git-feat-image-sizing-shopware-pwa.vercel.app

@github-actions
Copy link

github-actions bot commented Apr 14, 2021

💙 shopware-pwa-canary successfully deployed at https://a0a8cdbf6e2ed6a97c80cd9971634f40f3470206.shopware-pwa-canary.preview.storefrontcloud.io

@vercel vercel bot temporarily deployed to preview April 15, 2021 08:58 Inactive
@vercel vercel bot temporarily deployed to preview April 15, 2021 09:35 Inactive
@vercel vercel bot temporarily deployed to preview April 15, 2021 10:26 Inactive
@vercel vercel bot temporarily deployed to preview April 15, 2021 11:25 Inactive
@vercel vercel bot temporarily deployed to preview April 15, 2021 12:01 Inactive
@vercel vercel bot temporarily deployed to preview April 15, 2021 12:21 Inactive
@vercel vercel bot temporarily deployed to preview April 15, 2021 12:36 Inactive
@patzick patzick marked this pull request as ready for review April 15, 2021 12:42
@patzick patzick marked this pull request as draft April 15, 2021 12:42
@vercel vercel bot temporarily deployed to preview April 15, 2021 12:48 Inactive
@vercel vercel bot temporarily deployed to preview April 15, 2021 13:00 Inactive
@vercel vercel bot temporarily deployed to preview April 15, 2021 13:15 Inactive
@vercel vercel bot temporarily deployed to preview April 15, 2021 13:31 Inactive
@vercel vercel bot temporarily deployed to preview April 15, 2021 20:21 Inactive
@vercel vercel bot temporarily deployed to preview April 15, 2021 20:37 Inactive
@vercel vercel bot temporarily deployed to preview April 16, 2021 07:50 Inactive
@vercel vercel bot temporarily deployed to preview April 16, 2021 08:11 Inactive
@vercel vercel bot temporarily deployed to preview April 16, 2021 08:30 Inactive
@vercel vercel bot temporarily deployed to preview April 16, 2021 12:09 Inactive
@vercel vercel bot temporarily deployed to preview April 16, 2021 12:50 Inactive
@vercel vercel bot temporarily deployed to preview April 16, 2021 13:02 Inactive
@vercel vercel bot temporarily deployed to preview April 16, 2021 13:17 Inactive
@vercel vercel bot temporarily deployed to preview April 16, 2021 14:19 Inactive
@patzick patzick requested a review from mkucmus April 16, 2021 16:02
@patzick patzick marked this pull request as ready for review April 16, 2021 16:02
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ mkucmus
❌ patzick
You have signed the CLA already but the status is still pending? Let us recheck it.

@vercel vercel bot temporarily deployed to preview May 14, 2021 11:34 Inactive
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖼️ 💯

* Method to change URL of the image before fetching it from the server.
* Allow to use different CDN or put additional properties (like size) to URL.
*
* With optional EXPERIMENTAL_IMAGE_PROCESSING_SERVER flag as the env property. As an example for our demo instance .env looks like
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 what a great config for that!

@patzick patzick merged commit c812545 into master May 14, 2021
@patzick patzick deleted the feat/image-sizing branch May 14, 2021 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants