Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

fix(default-theme): revert destructuring of props in SwCartProduct #1618

Conversation

LouisEiermann
Copy link
Contributor

Changes

reverted the destructuring of props in setup() of SwCartProduct to prevent loss of reactivity: closes #1615

Checklist

Sorry, something went wrong.

Unverified

No user is associated with the committer email.
Update Master

Unverified

No user is associated with the committer email.
Update Master

Verified

This commit was signed with the committer’s verified signature. The key has expired.
MylesBorins Myles Borins

Verified

This commit was signed with the committer’s verified signature. The key has expired.
MylesBorins Myles Borins

Verified

This commit was signed with the committer’s verified signature. The key has expired.
MylesBorins Myles Borins

Verified

This commit was signed with the committer’s verified signature. The key has expired.
MylesBorins Myles Borins

Verified

This commit was signed with the committer’s verified signature. The key has expired.
MylesBorins Myles Borins

Verified

This commit was signed with the committer’s verified signature. The key has expired.
MylesBorins Myles Borins

Verified

This commit was signed with the committer’s verified signature. The key has expired.
MylesBorins Myles Borins

Verified

This commit was signed with the committer’s verified signature. The key has expired.
MylesBorins Myles Borins

Verified

This commit was signed with the committer’s verified signature. The key has expired.
MylesBorins Myles Borins

Verified

This commit was signed with the committer’s verified signature. The key has expired.
MylesBorins Myles Borins

Verified

This commit was signed with the committer’s verified signature.
cjihrig Colin Ihrig

Partially verified

This commit is signed with the committer’s verified signature.
cjihrig’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.

Verified

This commit was signed with the committer’s verified signature.
addaleax Anna Henningsen

Verified

This commit was signed with the committer’s verified signature.
addaleax Anna Henningsen

Verified

This commit was signed with the committer’s verified signature.
codebytere Shelley Vohr

Verified

This commit was signed with the committer’s verified signature.
codebytere Shelley Vohr

Verified

This commit was signed with the committer’s verified signature.
codebytere Shelley Vohr

Verified

This commit was signed with the committer’s verified signature.
codebytere Shelley Vohr

Verified

This commit was signed with the committer’s verified signature.
codebytere Shelley Vohr

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@vercel
Copy link

vercel bot commented Aug 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/APFS3zu3F2WEzBDvNDzv7eXYPq4N
✅ Preview: Canceled

Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👌

@patzick patzick merged commit f44d780 into vuestorefront:master Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Destructuring of props in SwCartProduct leads to removal of reactivity
3 participants