Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

Feat plugin slots #695

Merged
merged 13 commits into from
May 6, 2020
Merged

Feat plugin slots #695

merged 13 commits into from
May 6, 2020
+1,104 −307

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented May 5, 2020

Changes

closes #617

Docs:
https://shopware-pwa-docs-git-feat-plugin-slots.shopware-pwa.now.sh/guide/plugins.html

Provides a way to:

  • implement plugin locally in project
  • override plugins
  • extend plugins (multiple in a single slot)
  • slots in theme

Checklist

Sorry, something went wrong.

@vercel
Copy link

vercel bot commented May 5, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/14bapynun
✅ Preview: https://shopware-pwa-docs-git-feat-plugin-slots.shopware-pwa.now.sh

@github-actions
Copy link

github-actions bot commented May 5, 2020 •
edited
Loading

💙 shopware-pwa successfully deployed at https://e6823f8c7e65d8b9f9d3637e29d6406ff32214b0.shopware-pwa.preview.storefrontcloud.io

@vercel vercel bot temporarily deployed to preview May 5, 2020 13:43 Inactive
elkmod
elkmod reviewed May 5, 2020
View reviewed changes
elkmod
elkmod reviewed May 5, 2020
View reviewed changes
@vercel vercel bot temporarily deployed to preview May 5, 2020 17:47 Inactive
@vercel vercel bot temporarily deployed to Preview May 5, 2020 18:34 Inactive
@patzick
Merge branch 'master' into feat-plugin-slots

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
8c00e34
@vercel vercel bot temporarily deployed to preview May 5, 2020 18:35 Inactive
mkucmus
mkucmus reviewed May 6, 2020
View reviewed changes
packages/cli/src/commands/plugins.ts

const allowDevMode = !!inputParameters.devMode;

await toolbox.loadPluginsAssets();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future, we should prevent some possible timeouts/errors during the downloading and extracting/processing the cms components from SW6. I believe it can be even 20 plugins maybe more with a considerable size.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, for now, it has loading indicator with CLI, we'll add something here when we will face real issue to test :)

@patzick patzick added this to the v0.1.0-alpha.5 milestone May 6, 2020
@vercel vercel bot temporarily deployed to preview May 6, 2020 08:38 Inactive
mkucmus
mkucmus approved these changes May 6, 2020
View reviewed changes
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

elkmod
elkmod approved these changes May 6, 2020
View reviewed changes
Copy link
Collaborator

@elkmod elkmod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me :)

@patzick patzick merged commit 9c232bb into master May 6, 2020
@patzick patzick deleted the feat-plugin-slots branch May 6, 2020 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkucmus mkucmus

@elkmod elkmod

@Michal-Dziedzinski Michal-Dziedzinski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0-alpha.5
Development

Successfully merging this pull request may close these issues.

Implement named plugin slots
3 participants
@patzick @mkucmus @elkmod