Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

fix(default-theme): remove button on product page #883

Merged
merged 4 commits into from
Jun 25, 2020
Merged

fix(default-theme): remove button on product page #883

merged 4 commits into from
Jun 25, 2020
+3 −20

Conversation

Malwurf
Copy link
Collaborator

@Malwurf Malwurf commented Jun 22, 2020 •
edited
Loading

Changes

  • removed save for later button
  • removed add to compare button
  • removed unnecessary SwButton import component

Checklist

Sorry, something went wrong.

fix(default-theme): remove button on product page

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
GPG key ID: 1B38D43B1E40326D
Verified
Learn about vigilant mode
2804955 
remove save for later button

remove add to compare button

remove unnecessary SwButton import component
@vercel
Copy link

vercel bot commented Jun 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/heunrydxm
✅ Preview: https://shopware-pwa-docs-git-fix-save-for-later-button-864.shopware-pwa.vercel.app

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2020 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ mkucmus
✅ patzick
✅ Malwurf
❌ Krecik

Krecik seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Malwurf
Merge branch 'master' into fix/save-for-later-button-#864

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
GPG key ID: 1B38D43B1E40326D
Verified
Learn about vigilant mode
a8c7ef5
@vercel vercel bot temporarily deployed to preview June 23, 2020 08:09 Inactive
@github-actions
Copy link

github-actions bot commented Jun 23, 2020 •
edited
Loading

💙 shopware-pwa-canary successfully deployed at https://0c52f87cda8173ebdd3421994566bf6b51fd6c49.shopware-pwa-canary.preview.storefrontcloud.io

@vercel vercel bot temporarily deployed to preview June 23, 2020 13:03 Inactive
akrajna
akrajna approved these changes Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@akrajna akrajna mentioned this pull request Jun 23, 2020
Closed
@vercel vercel bot temporarily deployed to preview June 25, 2020 10:19 Inactive
@patzick patzick merged commit cefec52 into master Jun 25, 2020
@patzick patzick deleted the fix/save-for-later-button-#864 branch June 25, 2020 10:21
@patzick
Copy link
Collaborator

patzick commented Jun 25, 2020

related #864, #865

@patzick patzick mentioned this pull request Jun 25, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@patzick patzick

@akrajna akrajna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Malwurf @CLAassistant @patzick @akrajna @mkucmus