Skip to content
This repository was archived by the owner on Oct 31, 2024. It is now read-only.

feat(default-theme): handle product-three-column, text-three-column a… #977

Merged
merged 4 commits into from
Aug 5, 2020

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Jul 29, 2020

…nd text-two-column block types

Changes

closes #966

implemented cms blocks:

  • text three columns
  • text two columns
  • product three columns

Checklist

Sorry, something went wrong.

@vercel
Copy link

vercel bot commented Jul 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/d631lj3z3
✅ Preview: https://shopware-pwa-docs-git-feat-cms-not-implemented-components-966.shopware-pwa.vercel.app

@github-actions
Copy link

github-actions bot commented Jul 29, 2020

💙 shopware-pwa-canary successfully deployed at https://2a869ee264a1a4d65b811c21d820f1588bb63b77.shopware-pwa-canary.preview.storefrontcloud.io

@akrajna
Copy link
Collaborator

akrajna commented Jul 29, 2020

text three columns and text two columns:
on mobiles with small resolution as iPhone 6S, the spaces between each text section is too narrow:
3colunTextOnMobile
also the part of the text at very bottom is hiding partly under the component below:
3columnTextUnderFooter
or overlaying the component, as below:
3columntext

Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

product three columns:

  • the description under product pictures overlays content below
  • the product pictures have different sizing

3products

- on mobile the price of one product is cut

mobile3products

@vercel vercel bot temporarily deployed to preview July 31, 2020 16:23 Inactive

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vercel vercel bot temporarily deployed to preview July 31, 2020 16:39 Inactive
@vercel vercel bot temporarily deployed to preview August 4, 2020 11:52 Inactive
@patzick patzick requested a review from akrajna August 4, 2020 11:53
@patzick patzick merged commit a9bc5a4 into master Aug 5, 2020
@patzick patzick deleted the feat/cms-not-implemented-components-#966 branch August 5, 2020 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CMS - not implemented components
3 participants