All disabled sites include a wildcard in MV3

[ghostwords]

Because we use requestDomains in DNR "allowAllRequests" rules, disabled site domains always include subdomains.

Is it important to be able to disable Privacy Badger on site without disabling it on subdomains of that site?

If the answer is no, we should update MV2 Privacy Badger to work the same way, and remove the leading wildcard from the disabled sites domain input placeholder and any documentation. We should also update the validation for the disabled sites input, and remove wildcards from any existing disabled sites.

DNR "allowAllRequests" rules:

privacybadger/src/lib/dnr/utils.js

Lines 445 to 467 in 7d8d051

	// remove leading wildcards
	// domains now always match subdomains
	disabledSites = disabledSites.map(site => {
	if (site.startsWith('*')) {
	site = site.slice(1);
	if (site.startsWith('.')) {
	site = site.slice(1);
	}
	}
	return site;
	});
	if (disabledSites.length) {
	opts.addRules.push({
	id: badger.getDynamicRuleId(),
	priority: constants.DNR_SITE_ALLOW_ALL,
	action: { type: 'allowAllRequests' },
	condition: {
	requestDomains: disabledSites,
	resourceTypes: ['main_frame']
	}
	});
	}

Content script matching logic that we made to work the same way:

privacybadger/src/lib/dnr/utils.js

Lines 36 to 46 in 7d8d051

	function convertSiteDomainsToMatchPatterns(disabledSites) {
	return disabledSites.map(site => {
	if (site.startsWith("*")) {
	site = site.slice(1);
	if (site.startsWith(".")) {
	site = site.slice(1);
	}
	}
	return `*://*.${site}/*`;
	});
	}

[ghostwords]

To be exact, when you disable Privacy Badger on example.com in MV3, this is equivalent to the following disabled sites entries in MV2:

example.com
*.example.com

MV2 technically also supports *example.com, but MV3 does not, and I don't think we should support this either.

Relevant MV2 disabled site domain matching logic:

privacybadger/src/js/background.js

Line 996 in cbd036a

if (pattern.startsWith("*") && host.endsWith(pattern.slice(1))) {

[Mikaela]

Reading better, I think consistency is the way to go and thus my answer would be no, disabling a site without disabling subdomains is not important.

Otherwise I would imagine there to be confusion with mismatching behaviour of tracking sites, if anyone noticed it, and I try to keep my policies in sync between Firefox and Chromium, which I understand to be MV2 and MV3 in that order.