[Cases] Align cases lint rules with security solution (elastic#117177)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Author: cnasikas

.eslintrc.js

@@ -902,17 +902,6 @@ module.exports = {
       },
     },
 
-    /**
-     * Cases overrides
-     */
-    {
-      files: ['x-pack/plugins/cases/**/*.{js,mjs,ts,tsx}'],
-      rules: {
-        'no-duplicate-imports': 'off',
-        '@typescript-eslint/no-duplicate-imports': ['error'],
-      },
-    },
-
     /**
      * Security Solution overrides. These rules below are maintained and owned by
      * the people within the security-solution-platform team. Please see ping them
@@ -928,6 +917,8 @@ module.exports = {
         'x-pack/plugins/security_solution/common/**/*.{js,mjs,ts,tsx}',
         'x-pack/plugins/timelines/public/**/*.{js,mjs,ts,tsx}',
         'x-pack/plugins/timelines/common/**/*.{js,mjs,ts,tsx}',
+        'x-pack/plugins/cases/public/**/*.{js,mjs,ts,tsx}',
+        'x-pack/plugins/cases/common/**/*.{js,mjs,ts,tsx}',
       ],
       rules: {
         'import/no-nodejs-modules': 'error',
@@ -949,10 +940,12 @@ module.exports = {
       files: [
         'x-pack/plugins/security_solution/**/*.{ts,tsx}',
         'x-pack/plugins/timelines/**/*.{ts,tsx}',
+        'x-pack/plugins/cases/**/*.{ts,tsx}',
       ],
       excludedFiles: [
         'x-pack/plugins/security_solution/**/*.{test,mock,test_helper}.{ts,tsx}',
         'x-pack/plugins/timelines/**/*.{test,mock,test_helper}.{ts,tsx}',
+        'x-pack/plugins/cases/**/*.{test,mock,test_helper}.{ts,tsx}',
       ],
       rules: {
         '@typescript-eslint/no-non-null-assertion': 'error',
@@ -963,6 +956,7 @@ module.exports = {
       files: [
         'x-pack/plugins/security_solution/**/*.{ts,tsx}',
         'x-pack/plugins/timelines/**/*.{ts,tsx}',
+        'x-pack/plugins/cases/**/*.{ts,tsx}',
       ],
       rules: {
         '@typescript-eslint/no-this-alias': 'error',
@@ -985,6 +979,7 @@ module.exports = {
       files: [
         'x-pack/plugins/security_solution/**/*.{js,mjs,ts,tsx}',
         'x-pack/plugins/timelines/**/*.{js,mjs,ts,tsx}',
+        'x-pack/plugins/cases/**/*.{js,mjs,ts,tsx}',
       ],
       plugins: ['eslint-plugin-node', 'react'],
       env: {

x-pack/plugins/cases/common/api/runtime_types.ts

@@ -60,7 +60,7 @@ export const decodeOrThrow =
 const getExcessProps = (props: rt.Props, r: Record<string, unknown>): string[] => {
   const ex: string[] = [];
   for (const k of Object.keys(r)) {
-    if (!props.hasOwnProperty(k)) {
+    if (!Object.prototype.hasOwnProperty.call(props, k)) {
       ex.push(k);
     }
   }
@@ -89,5 +89,5 @@ export function excess<C extends rt.InterfaceType<rt.Props> | rt.PartialType<rt.
     codec.encode,
     codec.props
   );
-  return r as any;
+  return r as C;
 }

x-pack/plugins/cases/public/common/lib/kibana/kibana_react.mock.ts

@@ -5,6 +5,8 @@
  * 2.0.
  */
 
+/* eslint-disable react/display-name */
+
 import React from 'react';
 
 import { RecursivePartial } from '@elastic/eui/src/components/common';

x-pack/plugins/cases/public/components/__mock__/form.ts

@@ -36,7 +36,7 @@ export const mockFormHook = {
   __readFieldConfigFromSchema: jest.fn(),
 };
 
-export const getFormMock = (sampleData: any) => ({
+export const getFormMock = (sampleData: unknown) => ({
   ...mockFormHook,
   submit: () =>
     Promise.resolve({

x-pack/plugins/cases/public/components/all_cases/expanded_row.tsx

@@ -6,15 +6,15 @@
  */
 
 import React from 'react';
-import { EuiBasicTable as _EuiBasicTable } from '@elastic/eui';
+import { EuiBasicTable } from '@elastic/eui';
 import styled from 'styled-components';
 import { Case, SubCase } from '../../containers/types';
 import { CasesColumns } from './columns';
 import { AssociationType } from '../../../common';
 
 type ExpandedRowMap = Record<string, Element> | {};
 
-const EuiBasicTable: any = _EuiBasicTable;
+// @ts-expect-error TS2769
 const BasicTable = styled(EuiBasicTable)`
   thead {
     display: none;

x-pack/plugins/cases/public/components/all_cases/index.test.tsx

@@ -303,7 +303,10 @@ describe('AllCasesGeneric', () => {
 
     await waitFor(() => {
       result.current.map(
-        (i, key) => i.name != null && !i.hasOwnProperty('actions') && checkIt(`${i.name}`, key)
+        (i, key) =>
+          i.name != null &&
+          !Object.prototype.hasOwnProperty.call(i, 'actions') &&
+          checkIt(`${i.name}`, key)
       );
     });
   });
@@ -378,7 +381,9 @@ describe('AllCasesGeneric', () => {
       })
     );
     await waitFor(() => {
-      result.current.map((i) => i.name != null && !i.hasOwnProperty('actions'));
+      result.current.map(
+        (i) => i.name != null && !Object.prototype.hasOwnProperty.call(i, 'actions')
+      );
       expect(wrapper.find(`a[data-test-subj="case-details-link"]`).exists()).toBeFalsy();
     });
   });

x-pack/plugins/cases/public/components/all_cases/selector_modal/index.tsx

@@ -87,5 +87,8 @@ export const AllCasesSelectorModal: React.FC<AllCasesSelectorModalProps> = React
     </OwnerProvider>
   );
 });
+
+AllCasesSelectorModal.displayName = 'AllCasesSelectorModal';
+
 // eslint-disable-next-line import/no-default-export
 export { AllCasesSelectorModal as default };

x-pack/plugins/cases/public/components/all_cases/table.tsx

@@ -10,7 +10,7 @@ import {
   EuiEmptyPrompt,
   EuiLoadingContent,
   EuiTableSelectionType,
-  EuiBasicTable as _EuiBasicTable,
+  EuiBasicTable,
   EuiBasicTableProps,
 } from '@elastic/eui';
 import classnames from 'classnames';
@@ -40,12 +40,12 @@ interface CasesTableProps {
   selection: EuiTableSelectionType<Case>;
   showActions: boolean;
   sorting: EuiBasicTableProps<Case>['sorting'];
-  tableRef: MutableRefObject<_EuiBasicTable | undefined>;
+  tableRef: MutableRefObject<EuiBasicTable | undefined>;
   tableRowProps: EuiBasicTableProps<Case>['rowProps'];
   userCanCrud: boolean;
 }
 
-const EuiBasicTable: any = _EuiBasicTable;
+// @ts-expect-error TS2769
 const BasicTable = styled(EuiBasicTable)`
   ${({ theme }) => `
     .euiTableRow-isExpandedRow.euiTableRow-isSelectable .euiTableCellContent {

x-pack/plugins/cases/public/components/configure_cases/index.tsx

@@ -242,5 +242,7 @@ export const ConfigureCases: React.FC<ConfigureCasesProps> = React.memo((props)
   );
 });
 
+ConfigureCases.displayName = 'ConfigureCases';
+
 // eslint-disable-next-line import/no-default-export
 export default ConfigureCases;

x-pack/plugins/cases/public/components/connectors/connectors_registry.ts

@@ -9,8 +9,25 @@ import { i18n } from '@kbn/i18n';
 import { CaseConnector, CaseConnectorsRegistry } from './types';
 
 export const createCaseConnectorsRegistry = (): CaseConnectorsRegistry => {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const connectors: Map<string, CaseConnector<any>> = new Map();
 
+  function assertConnectorExists(
+    connector: CaseConnector | undefined | null,
+    id: string
+  ): asserts connector {
+    if (!connector) {
+      throw new Error(
+        i18n.translate('xpack.cases.connecors.get.missingCaseConnectorErrorMessage', {
+          defaultMessage: 'Object type "{id}" is not registered.',
+          values: {
+            id,
+          },
+        })
+      );
+    }
+  }
+
   const registry: CaseConnectorsRegistry = {
     has: (id: string) => connectors.has(id),
     register: <UIProps>(connector: CaseConnector<UIProps>) => {
@@ -28,17 +45,9 @@ export const createCaseConnectorsRegistry = (): CaseConnectorsRegistry => {
       connectors.set(connector.id, connector);
     },
     get: <UIProps>(id: string): CaseConnector<UIProps> => {
-      if (!connectors.has(id)) {
-        throw new Error(
-          i18n.translate('xpack.cases.connecors.get.missingCaseConnectorErrorMessage', {
-            defaultMessage: 'Object type "{id}" is not registered.',
-            values: {
-              id,
-            },
-          })
-        );
-      }
-      return connectors.get(id)!;
+      const connector = connectors.get(id);
+      assertConnectorExists(connector, id);
+      return connector;
     },
     list: () => {
       return Array.from(connectors).map(([id, connector]) => connector);

x-pack/plugins/cases/public/components/create/description.tsx

@@ -21,7 +21,7 @@ const DescriptionComponent: React.FC<Props> = ({ isLoading }) => {
     useLensDraftComment();
   const { setFieldValue } = useFormContext();
   const [{ title, tags }] = useFormData({ watch: ['title', 'tags'] });
-  const editorRef = useRef<Record<string, any>>();
+  const editorRef = useRef<Record<string, unknown>>();
 
   useEffect(() => {
     if (draftComment?.commentId === fieldName && editorRef.current) {

x-pack/plugins/cases/public/components/create/index.tsx

@@ -98,5 +98,8 @@ export const CreateCase: React.FC<CreateCaseProps> = React.memo((props) => (
     <CreateCaseComponent {...props} />
   </OwnerProvider>
 ));
+
+CreateCase.displayName = 'CreateCase';
+
 // eslint-disable-next-line import/no-default-export
 export { CreateCase as default };

x-pack/plugins/cases/public/components/markdown_editor/editor.tsx

@@ -96,4 +96,6 @@ const MarkdownEditorComponent = forwardRef<MarkdownEditorRef, MarkdownEditorProp
   }
 );
 
+MarkdownEditorComponent.displayName = 'MarkdownEditorComponent';
+
 export const MarkdownEditor = memo(MarkdownEditorComponent);

x-pack/plugins/cases/public/components/markdown_editor/eui_form.tsx

@@ -75,3 +75,5 @@ export const MarkdownEditorForm = React.memo(
     }
   )
 );
+
+MarkdownEditorForm.displayName = 'MarkdownEditorForm';

x-pack/plugins/cases/public/components/markdown_editor/plugins/lens/plugin.tsx

@@ -140,7 +140,7 @@ const LensEditorComponent: LensEuiMarkdownEditorUiPlugin['editor'] = ({
     });
 
     lens?.navigateToPrefilledEditor(undefined, {
-      originatingApp: currentAppId!,
+      originatingApp: currentAppId,
       originatingPath,
     });
   }, [
@@ -174,7 +174,7 @@ const LensEditorComponent: LensEuiMarkdownEditorUiPlugin['editor'] = ({
             }
           : undefined,
         {
-          originatingApp: currentAppId!,
+          originatingApp: currentAppId,
           originatingPath,
         }
       );
@@ -310,7 +310,6 @@ const LensEditorComponent: LensEuiMarkdownEditorUiPlugin['editor'] = ({
 
       if (draftComment) {
         handleAdd(incomingEmbeddablePackage?.input.attributes, newTimeRange);
-        return;
       }
     }
   }, [embeddable, storage, timefilter, currentAppId, handleAdd, handleUpdate, draftComment]);

x-pack/plugins/cases/public/components/markdown_editor/plugins/lens/saved_objects_finder.tsx

@@ -201,10 +201,10 @@ export class SavedObjectFinderUi extends React.Component<
 
   public render() {
     return (
-      <React.Fragment>
+      <>
         {this.renderSearchBar()}
         {this.renderListing()}
-      </React.Fragment>
+      </>
     );
   }
 
@@ -481,16 +481,23 @@ export class SavedObjectFinderUi extends React.Component<
               {items.map((item) => {
                 const currentSavedObjectMetaData = savedObjectMetaData.find(
                   (metaData) => metaData.type === item.type
-                )!;
+                );
+
+                if (currentSavedObjectMetaData == null) {
+                  return null;
+                }
+
                 const fullName = currentSavedObjectMetaData.getTooltipForSavedObject
                   ? currentSavedObjectMetaData.getTooltipForSavedObject(item.savedObject)
-                  : `${item.title} (${currentSavedObjectMetaData!.name})`;
+                  : `${item.title} (${currentSavedObjectMetaData.name})`;
+
                 const iconType = (
                   currentSavedObjectMetaData ||
                   ({
                     getIconForSavedObject: () => 'document',
                   } as Pick<SavedObjectMetaData<{ title: string }>, 'getIconForSavedObject'>)
                 ).getIconForSavedObject(item.savedObject);
+
                 return (
                   <EuiListGroupItem
                     key={item.id}

x-pack/plugins/cases/public/components/markdown_editor/plugins/lens/use_lens_button_toggle.ts

@@ -5,6 +5,8 @@
  * 2.0.
  */
 
+/* eslint-disable @typescript-eslint/no-non-null-assertion */
+
 import { some } from 'lodash';
 import useDebounce from 'react-use/lib/useDebounce';
 import { ContextShape } from '@elastic/eui/src/components/markdown_editor/markdown_context';
@@ -112,6 +114,7 @@ export const useLensButtonToggle = ({
             ) {
               if (child.type === 'text') break outer; // don't dive into `text` nodes
               node = child;
+              // eslint-disable-next-line no-continue
               continue outer;
             }
           }

x-pack/plugins/cases/public/components/markdown_editor/renderer.tsx

@@ -16,16 +16,25 @@ interface Props {
   disableLinks?: boolean;
 }
 
+const withDisabledLinks = (disableLinks?: boolean): React.FC<EuiLinkAnchorProps> => {
+  const MarkdownLinkProcessingComponent: React.FC<EuiLinkAnchorProps> = memo((props) => (
+    <MarkdownLink {...props} disableLinks={disableLinks} />
+  ));
+
+  MarkdownLinkProcessingComponent.displayName = 'MarkdownLinkProcessingComponent';
+
+  return MarkdownLinkProcessingComponent;
+};
+
 const MarkdownRendererComponent: React.FC<Props> = ({ children, disableLinks }) => {
   const { processingPlugins, parsingPlugins } = usePlugins();
-  const MarkdownLinkProcessingComponent: React.FC<EuiLinkAnchorProps> = useMemo(
-    () => (props) => <MarkdownLink {...props} disableLinks={disableLinks} />,
-    [disableLinks]
-  );
   // Deep clone of the processing plugins to prevent affecting the markdown editor.
   const processingPluginList = cloneDeep(processingPlugins);
   // This line of code is TS-compatible and it will break if [1][1] change in the future.
-  processingPluginList[1][1].components.a = MarkdownLinkProcessingComponent;
+  processingPluginList[1][1].components.a = useMemo(
+    () => withDisabledLinks(disableLinks),
+    [disableLinks]
+  );
 
   return (
     <EuiMarkdownFormat

x-pack/plugins/cases/public/components/recent_cases/index.tsx

@@ -100,5 +100,7 @@ export const RecentCases: React.FC<RecentCasesProps> = React.memo((props) => {
   );
 });
 
+RecentCases.displayName = 'RecentCases';
+
 // eslint-disable-next-line import/no-default-export
 export { RecentCases as default };

x-pack/plugins/cases/public/components/user_action_tree/helpers.tsx

@@ -396,6 +396,8 @@ const ActionIcon = React.memo<{
   );
 });
 
+ActionIcon.displayName = 'ActionIcon';
+
 export const getActionAttachment = ({
   comment,
   userCanCrud,