Skip to content

Commit 970ce14

Browse files
committed
crypto: remove deperecated methods of TLS version
All version-specific methods were deprecated in OpenSSL 1.1.0 and min/max versions explicitly need to be set. This still keeps comptatible with JS and OpenSSL-1.0.2 APIs for now. crypto, constants: add constant of OpenSSL-1.1.0 Several constants for OpenSSL-1.1.0 engine were removed and renamed in OpenSSL-1.1.0. This added one renamed constant in order to have a compatible feature with that of OpenSSL-1.0.2. Other missed or new constants in OpenSSL-1.1.0 are not yet added. crypto,tls,constants: remove OpenSSL1.0.2 support This is semver-majar change so that we need not to have compatibilities with older versions. Fixes: nodejs#4270 PR-URL: nodejs#19794 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 2b23583 commit 970ce14

File tree

2 files changed

+36
-218
lines changed

2 files changed

+36
-218
lines changed

src/node_constants.cc

+2-10
Original file line numberDiff line numberDiff line change
@@ -917,12 +917,8 @@ void DefineOpenSSLConstants(Local<Object> target) {
917917
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_RAND);
918918
# endif
919919

920-
# ifdef ENGINE_METHOD_ECDH
921-
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_ECDH);
922-
# endif
923-
924-
# ifdef ENGINE_METHOD_ECDSA
925-
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_ECDSA);
920+
# ifdef ENGINE_METHOD_EC
921+
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_EC);
926922
# endif
927923

928924
# ifdef ENGINE_METHOD_CIPHERS
@@ -933,10 +929,6 @@ void DefineOpenSSLConstants(Local<Object> target) {
933929
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_DIGESTS);
934930
# endif
935931

936-
# ifdef ENGINE_METHOD_STORE
937-
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_STORE);
938-
# endif
939-
940932
# ifdef ENGINE_METHOD_PKEY_METHS
941933
NODE_DEFINE_CONSTANT(target, ENGINE_METHOD_PKEY_METHS);
942934
# endif

0 commit comments

Comments
 (0)