Ticket OscarGodson#233 - making autosaves only happen when text has changed, tweaking what is an autosave

Author: Alexis Beingessner

epiceditor/js/epiceditor.js

@@ -1340,7 +1340,7 @@
       }
       else {
         _setText(self.editor, defaultContent);
-        self.save(false, true); // ensure a save
+        self.save(); // ensure a save
         self.emit('create');
       }
       self.previewer.innerHTML = self.exportFile(null, 'html');
@@ -1386,6 +1386,10 @@
         storage[file].modified = new Date();
         isUpdate = true;
       }
+      //don't bother autosaving if the content hasn't actually changed
+      else if (_isAuto) {
+        return;
+      }
 
       storage[file].content = content;
       this._storage[previewDraftName + self.settings.localStorageName] = JSON.stringify(storage);
@@ -1396,11 +1400,11 @@
         // Emit a private update event so it can't get accidentally removed
         self.emit('__update');
       }
-      
-      if (_isAuto || _isPreviewDraft) {
+
+      if (_isAuto) {
         this.emit('autosave');
       }
-      else {
+      else if (!_isPreviewDraft) {
         this.emit('save');
       }
     }
@@ -1475,7 +1479,7 @@
       self.emit('create');
     }
 
-    self.save(false, true);
+    self.save();
 
     if (self.is('fullscreen')) {
       self.preview();

epiceditor/js/epiceditor.min.js

@@ -1340,7 +1340,7 @@
       }
       else {
         _setText(self.editor, defaultContent);
-        self.save(false, true); // ensure a save
+        self.save(); // ensure a save
         self.emit('create');
       }
       self.previewer.innerHTML = self.exportFile(null, 'html');
@@ -1386,6 +1386,10 @@
         storage[file].modified = new Date();
         isUpdate = true;
       }
+      //don't bother autosaving if the content hasn't actually changed
+      else if (_isAuto) {
+        return;
+      }
 
       storage[file].content = content;
       this._storage[previewDraftName + self.settings.localStorageName] = JSON.stringify(storage);
@@ -1396,11 +1400,11 @@
         // Emit a private update event so it can't get accidentally removed
         self.emit('__update');
       }
-      
-      if (_isAuto || _isPreviewDraft) {
+
+      if (_isAuto) {
         this.emit('autosave');
       }
-      else {
+      else if (!_isPreviewDraft) {
         this.emit('save');
       }
     }
@@ -1475,7 +1479,7 @@
       self.emit('create');
     }
 
-    self.save(false, true);
+    self.save();
 
     if (self.is('fullscreen')) {
       self.preview();

src/editor.js

@@ -56,11 +56,35 @@ describe('.save()', function () {
     editor.on('autosave', function () {
       eventFired = true;
     });
-    editor.save(true);
+    editor.getElement('editor').body.innerHTML = 'bar';
+    editor.save(false, true);
     expect(eventFired).to.be(true);
     expect(badEventFired).to.be(false);
   });
 
+  it('should not fire an event', function () {
+    editor.on('save', function () {
+      badEventFired = true;
+    });
+    editor.on('autosave', function () {
+      badEventFired = true;
+    });
+    editor.save(true);
+    expect(badEventFired).to.be(false);
+  });
+
+  it('should fire the autosave event only once', function () {
+    editor.on('autosave', function () {
+      eventFired = true;
+    });
+    editor.getElement('editor').body.innerHTML = 'bar';
+    editor.save(false, true);
+    expect(eventFired).to.be(true);
+    eventFired = false;
+    editor.save(false, true);
+    expect(eventFired).to.be(false);
+  });
+
   it('should fire the update event on save when the content has changed', function () {
     editor.on('update', function () {
       eventFired = true;