Skip to content

Commit 04ea39d

Browse files
committed
generate schemas
1 parent 82f9a2b commit 04ea39d

File tree

5 files changed

+39
-58
lines changed

5 files changed

+39
-58
lines changed

docs/content/en/schemas/v2beta7.json

+1-37
Original file line numberDiff line numberDiff line change
@@ -923,11 +923,6 @@
923923
"x-intellij-html-description": "used to pass in --no-cache to docker build to prevent caching.",
924924
"default": "false"
925925
},
926-
"secret": {
927-
"$ref": "#/definitions/DockerSecret",
928-
"description": "contains information about a local secret passed to `docker build`, along with optional destination information.",
929-
"x-intellij-html-description": "contains information about a local secret passed to <code>docker build</code>, along with optional destination information."
930-
},
931926
"target": {
932927
"type": "string",
933928
"description": "Dockerfile target name to build.",
@@ -940,8 +935,7 @@
940935
"buildArgs",
941936
"network",
942937
"cacheFrom",
943-
"noCache",
944-
"secret"
938+
"noCache"
945939
],
946940
"additionalProperties": false,
947941
"description": "describes an artifact built from a Dockerfile, usually using `docker build`.",
@@ -968,36 +962,6 @@
968962
"description": "contains information about the docker `config.json` to mount.",
969963
"x-intellij-html-description": "contains information about the docker <code>config.json</code> to mount."
970964
},
971-
"DockerSecret": {
972-
"required": [
973-
"id"
974-
],
975-
"properties": {
976-
"dst": {
977-
"type": "string",
978-
"description": "path in the container to mount the secret.",
979-
"x-intellij-html-description": "path in the container to mount the secret."
980-
},
981-
"id": {
982-
"type": "string",
983-
"description": "id of the secret.",
984-
"x-intellij-html-description": "id of the secret."
985-
},
986-
"src": {
987-
"type": "string",
988-
"description": "path to the secret on the host machine.",
989-
"x-intellij-html-description": "path to the secret on the host machine."
990-
}
991-
},
992-
"preferredOrder": [
993-
"id",
994-
"src",
995-
"dst"
996-
],
997-
"additionalProperties": false,
998-
"description": "contains information about a local secret passed to `docker build`, along with optional destination information.",
999-
"x-intellij-html-description": "contains information about a local secret passed to <code>docker build</code>, along with optional destination information."
1000-
},
1001965
"DockerfileDependency": {
1002966
"properties": {
1003967
"buildArgs": {

docs/content/en/schemas/v2beta8.json

+37-1
Original file line numberDiff line numberDiff line change
@@ -923,6 +923,11 @@
923923
"x-intellij-html-description": "used to pass in --no-cache to docker build to prevent caching.",
924924
"default": "false"
925925
},
926+
"secret": {
927+
"$ref": "#/definitions/DockerSecret",
928+
"description": "contains information about a local secret passed to `docker build`, along with optional destination information.",
929+
"x-intellij-html-description": "contains information about a local secret passed to <code>docker build</code>, along with optional destination information."
930+
},
926931
"target": {
927932
"type": "string",
928933
"description": "Dockerfile target name to build.",
@@ -935,7 +940,8 @@
935940
"buildArgs",
936941
"network",
937942
"cacheFrom",
938-
"noCache"
943+
"noCache",
944+
"secret"
939945
],
940946
"additionalProperties": false,
941947
"description": "describes an artifact built from a Dockerfile, usually using `docker build`.",
@@ -962,6 +968,36 @@
962968
"description": "contains information about the docker `config.json` to mount.",
963969
"x-intellij-html-description": "contains information about the docker <code>config.json</code> to mount."
964970
},
971+
"DockerSecret": {
972+
"required": [
973+
"id"
974+
],
975+
"properties": {
976+
"dst": {
977+
"type": "string",
978+
"description": "path in the container to mount the secret.",
979+
"x-intellij-html-description": "path in the container to mount the secret."
980+
},
981+
"id": {
982+
"type": "string",
983+
"description": "id of the secret.",
984+
"x-intellij-html-description": "id of the secret."
985+
},
986+
"src": {
987+
"type": "string",
988+
"description": "path to the secret on the host machine.",
989+
"x-intellij-html-description": "path to the secret on the host machine."
990+
}
991+
},
992+
"preferredOrder": [
993+
"id",
994+
"src",
995+
"dst"
996+
],
997+
"additionalProperties": false,
998+
"description": "contains information about a local secret passed to `docker build`, along with optional destination information.",
999+
"x-intellij-html-description": "contains information about a local secret passed to <code>docker build</code>, along with optional destination information."
1000+
},
9651001
"DockerfileDependency": {
9661002
"properties": {
9671003
"buildArgs": {

integration/build_test.go

-18
Original file line numberDiff line numberDiff line change
@@ -36,24 +36,6 @@ import (
3636

3737
const imageName = "gcr.io/k8s-skaffold/simple-build:"
3838

39-
func TestBuildKit(t *testing.T) {
40-
MarkIntegrationTest(t, NeedsGcp)
41-
42-
dir := "testdata/build/secret"
43-
44-
// Run without artifact caching
45-
skaffold.Build("--cache-artifacts=false").InDir(dir).RunOrFail(t)
46-
47-
// Run with artifact caching
48-
skaffold.Build("--cache-artifacts=true").InDir(dir).RunOrFail(t)
49-
50-
// Run a second time with artifact caching
51-
out := skaffold.Build("--cache-artifacts=true").InDir(dir).RunOrFailOutput(t)
52-
if strings.Contains(string(out), "Not found. Building") {
53-
t.Errorf("images were expected to be found in cache: %s", out)
54-
}
55-
}
56-
5739
func TestBuild(t *testing.T) {
5840
MarkIntegrationTest(t, CanRunWithoutGcp)
5941

integration/testdata/build/secret/skaffold.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
apiVersion: skaffold/v2beta7
1+
apiVersion: skaffold/v2beta8
22
kind: Config
33
build:
44
local:

integration/testdata/build/skaffold.yaml

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ apiVersion: skaffold/v2beta8
22
kind: Config
33
build:
44
local:
5-
# useBuildkit: true
65
push: false
76
artifacts:
87
# A simple Docker build

0 commit comments

Comments
 (0)