Skip to content

Commit 0e1a3ac

Browse files
committed
fix test name and unnecessary variable
1 parent 35ef4ad commit 0e1a3ac

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

pkg/skaffold/deploy/deploy_mux.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -105,14 +105,13 @@ func (m DeployerMux) Deploy(ctx context.Context, w io.Writer, as []graph.Artifac
105105
w = output.WithEventContext(w, constants.Deploy, strconv.Itoa(i), "skaffold")
106106
ctx, endTrace := instrumentation.StartTrace(ctx, "Deploy")
107107

108-
var err error
109-
if err = deployer.Deploy(ctx, w, as); err != nil {
108+
if err := deployer.Deploy(ctx, w, as); err != nil {
110109
eventV2.DeployFailed(i, err)
111110
endTrace(instrumentation.TraceEndError(err))
112111
return err
113112
}
114113
if m.iterativeStatusCheck {
115-
if err = deployer.GetStatusMonitor().Check(ctx, w); err != nil {
114+
if err := deployer.GetStatusMonitor().Check(ctx, w); err != nil {
116115
eventV2.DeployFailed(i, err)
117116
endTrace(instrumentation.TraceEndError(err))
118117
return err

pkg/skaffold/deploy/util/util_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import (
2222
"github.com/GoogleContainerTools/skaffold/testutil"
2323
)
2424

25-
func TestRunContext_UpdateNamespaces(t *testing.T) {
25+
func TestConsolidateNamespaces(t *testing.T) {
2626
tests := []struct {
2727
description string
2828
oldNamespaces []string

0 commit comments

Comments
 (0)