use fake fs for offline unit test

Author: IsaacPD

cmd/skaffold/app/cmd/schema/print_test.go

@@ -18,45 +18,15 @@ package schema
 
 import (
 	"bytes"
-	"io"
 	"net/http"
-	"os"
 	"testing"
 
 	"github.com/GoogleContainerTools/skaffold/cmd/skaffold/app/cmd/statik"
 	"github.com/GoogleContainerTools/skaffold/testutil"
 )
 
-type fakeFileSystem struct {
-	Files map[string][]byte
-}
-
-type fakeFile struct {
-	http.File
-	content io.Reader
-}
-
-func (f *fakeFileSystem) Open(name string) (http.File, error) {
-	content, found := f.Files[name]
-	if !found {
-		return nil, os.ErrNotExist
-	}
-
-	return &fakeFile{
-		content: bytes.NewBuffer(content),
-	}, nil
-}
-
-func (f *fakeFile) Read(p []byte) (n int, err error) {
-	return f.content.Read(p)
-}
-
-func (f *fakeFile) Close() error {
-	return nil
-}
-
 func TestPrint(t *testing.T) {
-	fs := &fakeFileSystem{
+	fs := &testutil.FakeFileSystem{
 		Files: map[string][]byte{
 			"/schemas/v1.json": []byte("{SCHEMA}"),
 		},

pkg/skaffold/instrumentation/meter.go

@@ -104,7 +104,6 @@ func init() {
 
 func InitMeter(runCtx *runcontext.RunContext, config *latest.SkaffoldConfig) {
 	meter.Command = runCtx.Opts.Command
-	meter.PlatformType = yamltags.GetYamlTag(config.Build.BuildType)
 	for _, artifact := range config.Pipeline.Build.Artifacts {
 		if _, ok := meter.Builders[yamltags.GetYamlTag(artifact.ArtifactType)]; ok {
 			meter.Builders[yamltags.GetYamlTag(artifact.ArtifactType)]++

pkg/skaffold/instrumentation/meter_test.go

@@ -20,12 +20,14 @@ import (
 	"context"
 	"encoding/json"
 	"io/ioutil"
+	"net/http"
 	"os"
 	"testing"
 	"time"
 
 	"github.com/spf13/pflag"
 
+	"github.com/GoogleContainerTools/skaffold/cmd/skaffold/app/cmd/statik"
 	"github.com/GoogleContainerTools/skaffold/proto"
 	"github.com/GoogleContainerTools/skaffold/testutil"
 )
@@ -44,6 +46,17 @@ func TestOfflineExportMetrics(t *testing.T) {
 		Duration:       time.Minute,
 	}
 	validMeterBytes, _ := json.Marshal(validMeter)
+	fs := &testutil.FakeFileSystem{
+		Files: map[string][]byte{
+			"/keys.json": []byte(`{
+				"client_id": "test_id",
+				"client_secret": "test_secret",
+				"project_id": "test_project",
+				"refresh_token": "test_token",
+				"type": "authorized_user"
+			}`),
+		},
+	}
 
 	tests := []struct {
 		name                string
@@ -87,6 +100,7 @@ func TestOfflineExportMetrics(t *testing.T) {
 	for _, test := range tests {
 		testutil.Run(t, test.name, func(t *testutil.T) {
 			t.Override(&isOnline, false)
+			t.Override(&statik.FS, func() (http.FileSystem, error) { return fs, nil })
 			filename := "metrics"
 			tmp := t.NewTempDir()
 			var savedMetrics []skaffoldMeter

testutil/fake_fs.go

@@ -0,0 +1,52 @@
+/*
+Copyright 2020 The Skaffold Authors
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package testutil
+
+import (
+	"bytes"
+	"io"
+	"net/http"
+	"os"
+)
+
+type FakeFileSystem struct {
+	Files map[string][]byte
+}
+
+type fakeFile struct {
+	http.File
+	content io.Reader
+}
+
+func (f *FakeFileSystem) Open(name string) (http.File, error) {
+	content, found := f.Files[name]
+	if !found {
+		return nil, os.ErrNotExist
+	}
+
+	return &fakeFile{
+		content: bytes.NewBuffer(content),
+	}, nil
+}
+
+func (f *fakeFile) Read(p []byte) (n int, err error) {
+	return f.content.Read(p)
+}
+
+func (f *fakeFile) Close() error {
+	return nil
+}