Clear ApplicationLogEvent and SkaffoldLogEvent buffers on new dev iteration (#5993)

MarlonGamez · web-flow · commit 840f9b258156 · 2021-06-09T15:39:14.000-07:00
* clear user application and skaffold logs on new dev iteration

* use empty slice literals instead of nils
diff --git a/pkg/skaffold/event/v2/event.go b/pkg/skaffold/event/v2/event.go
@@ -305,8 +305,12 @@ func AutoTriggerDiff(phase constants.Phase, val bool) (bool, error) {
 }
 
 func TaskInProgress(task constants.Phase, description string) {
+	// Special casing to increment iteration and clear application and skaffold logs
 	if task == constants.DevLoop {
 		handler.iteration++
+
+		handler.applicationLogs = []proto.Event{}
+		handler.skaffoldLogs = []proto.Event{}
 	}
 
 	handler.handleTaskEvent(&proto.TaskEvent{

Original file line number	Diff line number	Diff line change
`@@ -305,8 +305,12 @@ func AutoTriggerDiff(phase constants.Phase, val bool) (bool, error) {`
`305`	`305`	`}`
`306`	`306`
`307`	`307`	`func TaskInProgress(task constants.Phase, description string) {`
	`308`	`+ // Special casing to increment iteration and clear application and skaffold logs`
`308`	`309`	`if task == constants.DevLoop {`
`309`	`310`	`handler.iteration++`
	`311`	`+`
	`312`	`+ handler.applicationLogs = []proto.Event{}`
	`313`	`+ handler.skaffoldLogs = []proto.Event{}`
`310`	`314`	`}`
`311`	`315`
`312`	`316`	`handler.handleTaskEvent(&proto.TaskEvent{`