Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to takeout the processed kubernetes YAML file #1187

Closed
ahmetb opened this issue Oct 22, 2018 · 9 comments
Closed

Ability to takeout the processed kubernetes YAML file #1187

ahmetb opened this issue Oct 22, 2018 · 9 comments

Comments

@ahmetb
Copy link
Contributor

ahmetb commented Oct 22, 2018

I think "skaffold build" command should allow doing something like:

skaffold build \
    --build-receipt out.json \
    --kubectl-manifests manifests.yaml

So I can actually decide whether I want to apply the manifests.yaml myself. Similarly, I can use out.json to parse out the built artifacts and store their names/tags for my own purposes.

Right now, "skaffold {build,run}" outputs aren't very usable. There should be a contract for those willing to parse output –or flags like this saving the results to a file.

This would solve #922 as well if the produced --build-receipt and --kubectl-manifests could be fed back into skaffold deploy command.

@r2d4
Copy link
Contributor

r2d4 commented Oct 22, 2018

This is somewhat of what I envisioned #726 providing. But this is a great idea.

@dgageot
Copy link
Contributor

dgageot commented Nov 8, 2018

Could it be a skaffold run --dry-run that outputs the manifests to stdout?

@r2d4
Copy link
Contributor

r2d4 commented Nov 8, 2018

How about “skaffold show build” to output what would be built + tags and “skaffold show deploy” to output what would be applied. “skaffold show” would return both?

@ahmetb
Copy link
Contributor Author

ahmetb commented Jan 14, 2019

Sorry for not replying earlier, these are good ideas.

Some form of reliable process to take out either the build artifacts and/or the compiled manifest would be very interesting.

@alnr
Copy link

alnr commented Jul 8, 2019

Note you can pass the --dry-run flag to your deployer of choice, but output is interleaved with skaffold logging (see #1937 (comment))

@edwin-zvs
Copy link

+1 for this issue.

https://zarvis.ai is probably the first PaaS that support Skaffold as a first class citizen out of the box (I work for zarvis.ai). I'd like to share our use case and how this feature can help us.

When user push a new commit, Zarvis internally do

  1. Clone repository
  2. skaffold build -q -o > build.out and save build.out for future use
  3. Deploy using skaffold deploy -a build.out
  4. Clean up

And when deploying the same commit later, Zarvis do

  1. Clone repository
  2. Load saved build.out
  3. Deploy using skaffold deploy -a build.out
  4. Clean up

The problem here is, skaffold deploy -a requires not only build.out but also source repository. And cloning repository can take long time (Store entire source repository with build.out is not an option for us, because of security reason). We're trying to re-deploy as quickly as possible and this feature will help a lot.

Skaffold is a great tool and we really love it. Thank everyone in the community for the great work.

@balopat
Copy link
Contributor

balopat commented Sep 6, 2019

That sounds great @edwin-zvs - thanks for sharing your use case, I'm excited to see Skaffold in your product (FYI the link on your main page is pointing to buildpacks.io ;)).

@edwin-zvs
Copy link

Thanks @balopat for the feedbacks. I just fixed the link in our website. Internally, we even use Skaffold's custom buildCommand to build project with buildpacks. Works like a charm!
Thanks again.

@balopat balopat added the priority/p0 Highest priority. We are actively looking at delivering it. label Sep 20, 2019
@tejal29 tejal29 added priority/p1 High impact feature/bug. and removed priority/p0 Highest priority. We are actively looking at delivering it. labels Sep 23, 2019
@tstromberg
Copy link
Contributor

I believe this was addressed by skaffold render. If incorrect, please add a comment and we'll reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants